Skip to content

vscode: 1.144.0 -> 1.146 - #586673

Merged
K900 merged 1 commit into
NixOS:masterfrom
Max-42:vscode-1.146
Nov 13, 2026
Merged

vscode: 1.144.0 -> 1.146#586673
K900 merged 1 commit into
NixOS:masterfrom
Max-42:vscode-1.146

Conversation

@Max-42

@Max-42 Max-42 commented Nov 11, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Updates Visual Studio Code from 1.144.0 to 1.146.0.

Changelog: https://code.visualstudio.com/updates/v1_146

Things done

@Max-42 Max-42 mentioned this pull request Nov 11, 2026
Closed
1 of 13 tasks
@nixpkgs-ci nixpkgs-ci Bot added 8.has: package (update) This PR updates a package to a newer version 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 6.topic: vscode A free and versatile code editor that supports almost every major programming language. labels Nov 11, 2026
@Max-42

Max-42 commented Nov 11, 2026

Copy link
Copy Markdown
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 586673
Commit: 34385279204a6f3f0cc3f435de27854f2851abee

x86_64-linux

✅ 3 packages built:
  • vscode
  • vscode-fhs
  • vscode-with-extensions

@Max-42
Max-42 marked this pull request as ready for review November 11, 2026 11:01
@nixpkgs-ci nixpkgs-ci Bot added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Nov 11, 2026
@K900
K900 added this pull request to the merge queue Nov 13, 2026
Merged via the queue into NixOS:master with commit 3fcfaf0 Nov 13, 2026
36 checks passed
siliconmeadow
siliconmeadow approved these changes Nov 13, 2026
View reviewed changes

@siliconmeadow siliconmeadow left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on x86_64-linux by building vscode from this PR’s head (nix-build .../archive/pull/586673/head.tar.gz -A vscode). It builds and launches as 1.146.0.

This also fixes
#584492, where 1.144.0 fails to build on the ripgrep rm. In the built output:

  • resources/app/node_modules/@vscode/ripgrep-universal/bin/linux-x64/rg is a symlink to nixpkgs’ ripgrep-15.2.0.
  • Ctrl+Shift+F file search works.

On NixOS 26.05 (stable), vscode currently fails to build because of this, so a backport to release-26.05 would be appreciated once this merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bobby285271 bobby285271 Awaiting requested review from bobby285271
@eadwu eadwu Awaiting requested review from eadwu
@JeffLabonte JeffLabonte Awaiting requested review from JeffLabonte
@JohnRTitor JohnRTitor Awaiting requested review from JohnRTitor
@oenu oenu Awaiting requested review from oenu
2 more reviewers
@siliconmeadow siliconmeadow siliconmeadow approved these changes
@yuannan yuannan yuannan approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

6.topic: vscode A free and versatile code editor that supports almost every major programming language. 8.has: package (update) This PR updates a package to a newer version 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Max-42 @siliconmeadow @yuannan @K900