Skip to content

nix-weather: remove unused cargoExtraArgs, enable structuredAttrs - #582582

Merged
SuperSandro2000 merged 2 commits into
NixOS:masterfrom
rntpts:sa-nix-weather
Nov 13, 2026
Merged

SuperSandro2000 merged 2 commits into
NixOS:masterfrom
rntpts:sa-nix-weather

Conversation

@rntpts

@rntpts rntpts commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

This option doesn't do anything as confirmed by the build log. This is the only occurrence in nixpkgs.

no change in CA hashes

Things done

@nixpkgs-ci
nixpkgs-ci Bot requested review from cafkafk and freyacodes November 3, 2026 08:16
@nixpkgs-ci nixpkgs-ci Bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Nov 3, 2026
@rntpts rntpts changed the title nix-weather: enable structuredAttrs nix-weather: remove unused cargoExtraArgs, enable structuredAttrs Nov 3, 2026
@SuperSandroBot

Copy link
Copy Markdown

✅ nixpkgs-review result

Generated using nixpkgs-review-gha (b97195b)

Command: nixpkgs-review pr 582582
Commit: 2e0d1ff2079669cb3aca790b9143af8cf328eedd (subsequent changes)
Merge: e1023b508ddd09bc0a8b2be30ca2a80c3c2372f5

Logs: https://github.com/SuperSandro2000/nixpkgs-review-gha/actions/runs/41667863336/attempts/1

Download packages from cache:
  • x86_64-linux
    nix-store -r \
      --option binary-caches 'https://cache.nixos.org/ https://gradient.c3d2.de/cache/nixpkgs-review-gha' \
      --option trusted-public-keys '
        cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
        gradient.c3d2.de-nixpkgs-review-gha:pXOmxNfDINod6RrtP069IQ9kXBga6IAz5K0PvUl7jLM=
      ' \
      /nix/store/4k5wd1mjldafixnmb2aqf3x756h10l1g-nix-weather-0.0.4-man \
      /nix/store/00qczg34rkm5kmmig4ayjh3m4dwmj4pv-nix-weather-0.0.4
  • aarch64-linux
    nix-store -r \
      --option binary-caches 'https://cache.nixos.org/ https://gradient.c3d2.de/cache/nixpkgs-review-gha' \
      --option trusted-public-keys '
        cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
        gradient.c3d2.de-nixpkgs-review-gha:pXOmxNfDINod6RrtP069IQ9kXBga6IAz5K0PvUl7jLM=
      ' \
      /nix/store/h3hzxwaa85i15f22wkpzdcwqma1hw40z-nix-weather-0.0.4-man \
      /nix/store/p3bidpz22nqqv0iiwmb3qmpylp9hp2gr-nix-weather-0.0.4

x86_64-linux

✅ 1 package built:
  • nix-weather

aarch64-linux

✅ 1 package built:
  • nix-weather

@nixpkgs-ci nixpkgs-ci Bot added 12.approvals: 1 This PR was reviewed and approved by one person. 2.status: merge-bot eligible This PR can be merged by commenting "@NixOS/nixpkgs-merge-bot merge". labels Nov 3, 2026
@SuperSandro2000
SuperSandro2000 added this pull request to the merge queue Nov 13, 2026
Merged via the queue into NixOS:master with commit b74a937 Nov 13, 2026
33 checks passed
@rntpts
rntpts deleted the sa-nix-weather branch November 13, 2026 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2.status: merge-bot eligible This PR can be merged by commenting "@NixOS/nixpkgs-merge-bot merge". 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants