Repository navigation
koboldcpp: fix runtime failure - #548986
Closed
fullmetalsheep wants to merge 1 commit into
Closed
fullmetalsheep wants to merge 1 commit into
fullmetalsheep wants to merge 1 commit into
Conversation
Member
|
There's #537338 already that does basically the same and more, but I don't mind this PR getting merged and rebasing on top of it either way |
Contributor
Author
I would prefer the rebase option since it takes away the pressure from your PRs' other changes? (on a purely selfish note, It'll also allow me to remove the local nix overlay I'm using to fix the issue - a bit faster 😆) Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Hello,
Current
installPhaselogic moves.embdfiles frombin/embd_restobin/. However,koboldcppstill looks upbin/embd_resfor .embd files. This disparity causes a runtime error (see below). This PR fixes it by preservingbin/embd_resfolder structure.I've built and tested this after with Steps to reproduce below, and koboldcpp embd lookup works.
Hope this helps,
Cheers!
Steps to reproduce (how I came across the issue)
koboldcpp --config ~/Downloads/starter-pack-v2.kcpptThings done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.