Skip to content

nixos/nordvpn: init module - #538312

Merged
romildo merged 1 commit into
NixOS:masterfrom
different-error:nordvpn
Jul 13, 2026
Merged

romildo merged 1 commit into
NixOS:masterfrom
different-error:nordvpn

Conversation

@different-error

@different-error different-error commented Jul 4, 2026 •

Copy link
Copy Markdown
Contributor

Things done

AI disclaimer: I wrote most of the code before Claude, but may have used Claude for feedback.

Other relevant prs: previous module pr, package pr.

I use the following configuration.nix file for building the vm:

{
  pkgs,
  ...
}:

{
  imports = [
    ./hardware-configuration.nix
  ];

  boot.loader.systemd-boot.enable = true;
  boot.loader.efi.canTouchEfiVariables = true;
  networking.firewall.enable = true;
  networking.firewall.checkReversePath = "loose";

  services.xserver.enable = true;
  services.displayManager.gdm.enable = true;
  services.desktopManager.plasma6.enable = true;

  environment.etc.hosts.mode = "0644";

  services.nordvpn = {
    enable = true;
    group = "alice";
  };

  virtualisation.vmVariant = {
    virtualisation = {
      memorySize = 8192;
      cores = 3;
    };
  };
  users.groups.alice = { };
  users.users.alice = {
    isNormalUser = true;
    password = "alice";
    group = "alice";
    extraGroups = [
      "wheel"
      "nordvpn"
    ];
    shell = pkgs.bash;
    home = "/home/alice";
    createHome = true;
    packages = with pkgs; [
      tree
      tmux
      dunst
      libnotify
      socat
      vim
      appimage-run
      firefox
      #nordvpn
    ];
  };
  system.stateVersion = "24.11"; # Did you read the comment?
}
nixos-rebuild build-vm -I nixpkgs=/path/to/nixpkgs -I nixos-config=/path/to/configuration.nix

@nixpkgs-ci nixpkgs-ci Bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog This PR adds or changes release notes 8.has: module (update) This PR changes an existing module in `nixos/` 8.has: documentation This PR adds or changes documentation labels Jul 4, 2026
@different-error different-error mentioned this pull request Jul 4, 2026
6 of 13 tasks
@different-error
different-error marked this pull request as ready for review July 4, 2026 06:56
@nixpkgs-ci
nixpkgs-ci Bot requested a review from GetPsyched July 4, 2026 07:43

@GetPsyched GetPsyched left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving redirects

@romildo

romildo commented Jul 12, 2026

Copy link
Copy Markdown
Contributor

This branch has conflicts that must be resolved before merging.

@nixpkgs-ci nixpkgs-ci Bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Jul 12, 2026
@different-error

Copy link
Copy Markdown
Contributor Author

Rebased on top of latest master. Verified that cli and gui work as expected.

@nixpkgs-ci nixpkgs-ci Bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Jul 12, 2026

@romildo romildo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nixpkgs-ci nixpkgs-ci Bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Jul 12, 2026
@romildo
romildo added this pull request to the merge queue Jul 13, 2026
Merged via the queue into NixOS:master with commit 60a1ba7 Jul 13, 2026
27 checks passed
@different-error
different-error deleted the nordvpn branch July 19, 2026 07:32
@h7x4 h7x4 added 8.has: module (new) This PR adds a module in `nixos/` 8.has: tests This PR has tests labels Jul 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog This PR adds or changes release notes 8.has: documentation This PR adds or changes documentation 8.has: module (new) This PR adds a module in `nixos/` 8.has: module (update) This PR changes an existing module in `nixos/` 8.has: tests This PR has tests 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants