Skip to content

kmod: 31 -> 34.2 - #525525

Open
joaosreis wants to merge 2 commits into
NixOS:stagingfrom
tweag:joaosreis/kmod-34
Open

joaosreis wants to merge 2 commits into
NixOS:stagingfrom
tweag:joaosreis/kmod-34

Conversation

@joaosreis

@joaosreis joaosreis commented May 29, 2026 •

Copy link
Copy Markdown
Member

Changelog: https://git.kernel.org/pub/scm/utils/kernel/kmod/kmod.git/plain/NEWS?h=v34.2

This PR also enables running upstream kmod tests.

Things done

nixpkgs-branch-check[bot]

This comment was marked as outdated.

@nixpkgs-ci nixpkgs-ci Bot added 8.has: package (update) This PR updates a package to a newer version 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. 10.rebuild-nixos-tests This PR causes rebuilds for all NixOS tests and should normally target the staging branches. labels May 29, 2026
@joaosreis
joaosreis changed the base branch from master to staging May 29, 2026 11:03
@nixpkgs-ci nixpkgs-ci Bot closed this May 29, 2026
@nixpkgs-ci nixpkgs-ci Bot reopened this May 29, 2026
@joaosreis
joaosreis force-pushed the joaosreis/kmod-34 branch from 97dd5ea to 0385d41 Compare May 29, 2026 11:05
@nixpkgs-branch-check
nixpkgs-branch-check Bot dismissed their stale review May 29, 2026 11:10

Review dismissed automatically

@joaosreis
joaosreis marked this pull request as ready for review June 1, 2026 07:57
@nixpkgs-ci
nixpkgs-ci Bot requested review from a team, Artturin and pyrox0 and removed request for a team June 1, 2026 09:30
@balsoft

balsoft commented Jul 31, 2026

Copy link
Copy Markdown
Member

@Artturin any feedback on this?

@pyrox0 pyrox0 moved this from Needs Review to Reviewed in Nixpkgs security review Jul 31, 2026
@joaosreis

Copy link
Copy Markdown
Member Author

I'm also proposing myself as a maintainer of this package. The package has a single maintainer at the moment, and the packaging underwent a major refactor to migrate from an autotools-based build to a meson-based one in this new release I'm authoring in this PR, so it makes sense to me to commit to helping maintain it here on forth as well.

@nixos-discourse

Copy link
Copy Markdown

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/tweag-nix-dev-update-58/79893/1

Comment thread pkgs/os-specific/linux/kmod/default.nix Outdated
(lib.mesonOption "modulesdirs" modulesDirs)
(lib.mesonBool "docs" withDevdoc)
(lib.mesonBool "manpages" true)
(lib.mesonBool "build-tests" doCheck)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use finalAttrs here

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just merged #576370 which does that

Comment thread pkgs/os-specific/linux/kmod/default.nix Outdated
Comment on lines +135 to +146
# The rest of the tests are disabled because they require extra setup
# ./testsuite/test-blacklist
# ./testsuite/test-dependencies
# ./testsuite/test-depmod
# ./testsuite/test-init
# ./testsuite/test-initstate
# ./testsuite/test-loaded
# ./testsuite/test-modinfo
# ./testsuite/test-modprobe
# ./testsuite/test-new-module
# ./testsuite/test-util
# ./testsuite/test-weakdep

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please drop this

@nixpkgs-ci nixpkgs-ci Bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Nov 4, 2026
@nixpkgs-ci nixpkgs-ci Bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Nov 5, 2026
@nixpkgs-ci nixpkgs-ci Bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Nov 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

8.has: package (update) This PR updates a package to a newer version 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. 10.rebuild-nixos-tests This PR causes rebuilds for all NixOS tests and should normally target the staging branches. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

Status: Reviewed

Development

Successfully merging this pull request may close these issues.

4 participants