Repository navigation
Answer F# scripts outside any project; ratchet coverage floors - #503
Merged
Merged
Conversation
CI's merged shards measured 97.26% for the Rust workspace and 98.41% for the VS Code extension on PR #494 (run 40451288370); each floor moves to the measurement less the gate's one-point tolerance: 95.8 -> 96.25 and 96.96 -> 97.4. [DIST-CI-COVERAGE-THRESHOLDS]
A script is never project-owned, but semantic queries only checked files against a loaded workspace. In a folder with no F# project the F# sidecar refused the workspace with "No .fsproj found" and every query on a script returned nothing; beside a project that does not list it, the script was checked under the project's options and answered nothing either. A directory or selection with no F# project now opens as an empty workspace, and a script that no loaded project or script compiles checks under the options its own directives resolve, with or without a workspace. Three tests asserted the old refusal; they now assert the empty workspace [SCRIPT-DEGRADE] requires. Refs #497. [SCRIPT-DETECT] [SCRIPT-FSX-OPTIONS]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two changes, each behind tests.
[SCRIPT-DETECT]), but semantic queries only checked files against a loaded workspace.[SCRIPT-DEGRADE]). A script that no loaded project or script compiles is checked under the options its own directives resolve ([SCRIPT-FSX-OPTIONS]), with or without a workspace.The full local ci-prep passed before this was pushed: every lint gate, the .NET suites (158, 488 and 839 tests), both Rust shards with 97.24% coverage, and all 16 VS Code chunks that run on macOS.
Refs #497. The issue closes once a released build is verified.