Test Explorer Debug builds, diagnostic accuracy and refresh; consolidate all branches

.deslop.toml

@@ -1,6 +1,6 @@
 # agent-pmo:a72c926
 [threshold]
-max_duplication_percent = 6.48
+max_duplication_percent = 5.95
 
 [defaults]
 exclude = [

.github/actions/build-platform/action.yml

@@ -98,6 +98,18 @@ runs:
       if: ${{ inputs.archive == 'true' }}
       shell: bash
       run: make _build-coverage-tools
+    - name: Stage the precompiled source-builder tests
+      if: ${{ inputs.archive == 'true' }}
+      shell: bash
+      run: make _build-lint-source-tests DOTNET_TESTS_PREBUILT=1
+    - name: Cache the source builder and verified upstream archive
+      if: ${{ inputs.archive == 'true' }}
+      uses: actions/upload-artifact@cf430e030ddbb5b0abf93d22962f4752f3646cd9 # v7.0.2
+      with:
+        name: lint-source-builder
+        retention-days: 1
+        if-no-files-found: error
+        path: target/lint-source-builder
     - name: Cache coverage report tools
       if: ${{ inputs.archive == 'true' }}
       uses: actions/upload-artifact@cf430e030ddbb5b0abf93d22962f4752f3646cd9 # v7.0.2
@@ -130,11 +142,11 @@ runs:
         include-hidden-files: true
         path: target/netcoredbg/${{ inputs.vsix-platform }}/netcoredbg
 
-    - uses: taiki-e/install-action@1168f6810a3cb30a3514bf5756a3b7f0422c6df8 # v2.87.28
+    - uses: taiki-e/install-action@8cca0918f8471c33515202b73f56ab27f2bed283 # v2.87.29
       if: ${{ inputs.archive == 'true' }}
       with:
         tool: cargo-llvm-cov
-    - uses: taiki-e/install-action@1168f6810a3cb30a3514bf5756a3b7f0422c6df8 # v2.87.28
+    - uses: taiki-e/install-action@8cca0918f8471c33515202b73f56ab27f2bed283 # v2.87.29
       if: ${{ inputs.archive == 'true' }}
       with:
         tool: nextest

.github/actions/vsix-shard/action.yml

@@ -119,6 +119,18 @@ runs:
         name: coverage-vsix-shard-${{ inputs.platform }}-${{ inputs.chunk }}
         retention-days: 1
         path: target/coverage-vsix-shard-${{ inputs.platform }}-${{ inputs.chunk }}.lcov
+    - name: Collect server and compiler logs
+      # The host and both sidecars log beneath the system temp folder, where the
+      # extension host's logs never reach: a compiler request that stops
+      # answering is visible only there. [DIST-CI-VSIX-SHARDS]
+      if: always()
+      shell: bash
+      run: |
+        logs="$(node -e 'process.stdout.write(require("os").tmpdir())')/sharplsp-logs"
+        if [ -d "$logs" ]; then
+          mkdir -p "${{ inputs.user-data-dir }}/logs"
+          cp -R "$logs" "${{ inputs.user-data-dir }}/logs/sharplsp-logs"
+        fi
     - name: Upload extension-host diagnostics
       # A chunk that fails or HANGS is exactly what the split exists to isolate,
       # so keep the extension-host logs for triage. Keep them for a GREEN chunk

.github/dependabot.yml

@@ -124,6 +124,37 @@ updates:
         applies-to: security-updates
         patterns: ["*"]
 
+  # Local video tooling has native image dependencies too.
+  - package-ecosystem: npm
+    directory: "/src/website/tools/video"
+    target-branch: "dependabot-upgrades"
+    schedule:
+      interval: weekly
+    open-pull-requests-limit: 5
+    labels: ["dependencies"]
+    groups:
+      video-tooling:
+        applies-to: version-updates
+        patterns: ["*"]
+      video-tooling-security:
+        applies-to: security-updates
+        patterns: ["*"]
+
+  - package-ecosystem: gradle
+    directory: "/src/editors/rider"
+    target-branch: "dependabot-upgrades"
+    schedule:
+      interval: weekly
+    open-pull-requests-limit: 5
+    labels: ["dependencies"]
+    groups:
+      rider-build:
+        applies-to: version-updates
+        patterns: ["*"]
+      rider-build-security:
+        applies-to: security-updates
+        patterns: ["*"]
+
   # ── GitHub Actions: all workflows ───────────────────────────────────
   # Version-only: GitHub publishes no Dependabot security advisories for
   # actions, so there is no security channel to group.

.github/workflows/ci-audit.yml

@@ -38,7 +38,7 @@ jobs:
       - uses: dtolnay/rust-toolchain@29eef336d9b2848a0b548edc03f92a220660cdb8 # stable
         with:
           toolchain: stable
-      - uses: taiki-e/install-action@1168f6810a3cb30a3514bf5756a3b7f0422c6df8 # v2.87.28
+      - uses: taiki-e/install-action@8cca0918f8471c33515202b73f56ab27f2bed283 # v2.87.29
         with:
           tool: cargo-audit
       - uses: actions/setup-dotnet@a98b56852c35b8e3190ac28c8c2271da59106c68 # v6.0.0

.github/workflows/ci-test-dotnet.yml

@@ -3,8 +3,9 @@
 # PHASE 4 — TEST. The .NET sidecar leg.
 #
 # EVERY TEST RUNS EXACTLY ONCE. The Ubuntu job runs the whole sidecar solution.
-# The Windows job runs ONLY the classes whose behaviour is platform-dependent -
-# named-pipe connection setup and the real sidecar handshake over those pipes
+# The Windows job runs ONLY tests whose behaviour is platform-dependent -
+# named-pipe connection setup, the real sidecar handshake, NTFS-held compiler reads
+# and project metadata sharing with editor saves
 # ([DIST-CI-WIN-TRANSPORT]).
 #
 # It used to run the entire SharpLsp.Sidecar.Common.Tests project instead, which
@@ -24,7 +25,13 @@ jobs:
   test-dotnet:
     name: Sidecars
     runs-on: ${{ vars.UBUNTU_RUNNER || 'ubuntu-latest' }}
-    timeout-minutes: 12
+    # The whole sidecar solution runs here (Common + C# + F# in parallel) under
+    # code coverage. The C# assembly alone is 833 real-SDK cases: ~4m15s on a
+    # 10-core host without coverage, so the 4-core runner with coverlet, a cold
+    # NuGet cache for the Razor/ASP.NET fixtures and the concurrent restore
+    # suites needs headroom above the old 12-minute cap (PR #494 hit it while
+    # main's smaller suite finished in 6m47s).
+    timeout-minutes: 20
     steps:
       - uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
         with:
@@ -91,7 +98,7 @@ jobs:
       - uses: ./.github/actions/dotnet-tests
         with:
           artifact: win-lsp-binaries-tests
-      - name: Test win32 named pipes and linked paths
+      - name: Test win32 named pipes, linked paths, compiler cancellation and editor saves
         # Only the platform-dependent classes. The full-solution `dotnet restore`
         # that used to precede this existed to cache the FCS nuspec for the
         # dependency-consistency tests, which are platform-agnostic and now run

.github/workflows/ci-test-editors.yml

@@ -39,10 +39,10 @@ jobs:
         with:
           toolchain: stable
           components: llvm-tools-preview
-      - uses: taiki-e/install-action@1168f6810a3cb30a3514bf5756a3b7f0422c6df8 # v2.87.28
+      - uses: taiki-e/install-action@8cca0918f8471c33515202b73f56ab27f2bed283 # v2.87.29
         with:
           tool: cargo-llvm-cov
-      - uses: taiki-e/install-action@1168f6810a3cb30a3514bf5756a3b7f0422c6df8 # v2.87.28
+      - uses: taiki-e/install-action@8cca0918f8471c33515202b73f56ab27f2bed283 # v2.87.29
         with:
           tool: nextest
       - uses: actions/setup-node@949feb2413d6458794dcd2491c4babbbce0c15c1 # v7.1.0

.github/workflows/ci-test-rust.yml

@@ -30,7 +30,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        shard: [1, 2]
+        shard: [ 1, 2 ]
     steps:
       - uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
         with:
@@ -39,10 +39,10 @@ jobs:
         with:
           toolchain: stable
           components: llvm-tools-preview
-      - uses: taiki-e/install-action@1168f6810a3cb30a3514bf5756a3b7f0422c6df8 # v2.87.28
+      - uses: taiki-e/install-action@8cca0918f8471c33515202b73f56ab27f2bed283 # v2.87.29
         with:
           tool: cargo-llvm-cov
-      - uses: taiki-e/install-action@1168f6810a3cb30a3514bf5756a3b7f0422c6df8 # v2.87.28
+      - uses: taiki-e/install-action@8cca0918f8471c33515202b73f56ab27f2bed283 # v2.87.29
         with:
           tool: nextest
       - uses: actions/setup-dotnet@a98b56852c35b8e3190ac28c8c2271da59106c68 # v6.0.0
@@ -54,8 +54,7 @@ jobs:
         with:
           path: "~/.nuget/packages"
           key: >-
-            ${{ runner.os }}-nuget-${{ hashFiles('src/sidecars/**/*.csproj',
-            'src/sidecars/Directory.Build.props') }}
+            ${{ runner.os }}-nuget-${{ hashFiles('src/sidecars/**/*.csproj', 'src/sidecars/Directory.Build.props') }}
           restore-keys: "${{ runner.os }}-nuget-"
       - uses: actions/setup-node@949feb2413d6458794dcd2491c4babbbce0c15c1 # v7.1.0
         with:
@@ -87,6 +86,17 @@ jobs:
         run: tar -xzf target/rust-fixtures.tar.gz
       - name: Test Rust shard with coverage
         run: env VSIX_PREBUILT=1 CARGO_TESTS_PREBUILT=1 make _test-rust-shard SHARD=${{ matrix.shard }} SHARD_COUNT=2
+      - name: Upload sidecar logs
+        # The e2e sidecars log beneath the temp folder. A failing shard keeps them,
+        # so a compiler failure only this runner shows is read, not guessed.
+        # [DIST-CI-RUST-SHARDS]
+        if: failure()
+        uses: actions/upload-artifact@cf430e030ddbb5b0abf93d22962f4752f3646cd9 # v7.0.2
+        with:
+          name: rust-sidecar-logs-shard-${{ matrix.shard }}
+          retention-days: 3
+          if-no-files-found: ignore
+          path: /tmp/sharplsp-logs
       - name: Upload shard coverage
         uses: actions/upload-artifact@cf430e030ddbb5b0abf93d22962f4752f3646cd9 # v7.0.2
         with:

.github/workflows/ci-test-tooling.yml

@@ -12,8 +12,8 @@
 # refusals: a digest mismatch must fail, must unpack nothing, and must NOT fall
 # back to compiling from source.
 #
-# Node's built-in runner, so this leg installs no dependencies and needs no
-# artifact from PHASE 2. It reports in well under a minute.
+# Node's built-in runner executes the source builder compiled in PHASE 2.
+# This consumer installs its runtime but never compiles the builder or product.
 name: CI / Test / Tooling
 'on':
   workflow_call: {}
@@ -31,5 +31,14 @@ jobs:
       - uses: actions/setup-node@949feb2413d6458794dcd2491c4babbbce0c15c1 # v7.1.0
         with:
           node-version: '20'
+      - uses: actions/setup-dotnet@a98b56852c35b8e3190ac28c8c2271da59106c68 # v6.0.0
+        with:
+          dotnet-version: 10.0.303
+      - uses: actions/download-artifact@9000827ccba6bdab643e8b6fd33ac0654aef8333 # v8.0.2
+        with:
+          name: lint-source-builder
+          path: target/lint-source-builder
       - name: Test the build tooling
+        env:
+          TOOLING_TESTS_PREBUILT: '1'
         run: make _test-tooling

.github/workflows/codeql.yml

@@ -20,9 +20,7 @@ on:
     inputs:
       gate:
         description: >-
-          When true, fail the job on any High/Critical finding so the calling
-          workflow (release.yml) blocks publishing. PR and weekly runs leave this
-          false and stay advisory (the PR check-failure threshold governs merges).
+          When true, fail the job on any High/Critical finding so the calling workflow (release.yml) blocks publishing. PR and weekly runs leave this false and stay advisory (the PR check-failure threshold governs merges).
         type: boolean
         default: false
 
@@ -70,15 +68,15 @@ jobs:
         with:
           submodules: true
       - name: Initialize CodeQL
-        uses: github/codeql-action/init@24c54180a607b1449ed407dd24f251e4e9147c8d # v4.38.3
+        uses: github/codeql-action/init@6f2ac81f5cd81fe351a197ba0b00d91d03cd2aee # v4.39.0
         with:
           languages: ${{ matrix.language }}
           build-mode: ${{ matrix.build-mode }}
           # Query suite and test-code exclusions live in the shared config so the
           # PR, weekly, and gated release scans stay identical. [DIST-CI-SECURITY]
           config-file: ./.github/codeql/codeql-config.yml
       - name: Perform CodeQL analysis
-        uses: github/codeql-action/analyze@24c54180a607b1449ed407dd24f251e4e9147c8d # v4.38.3
+        uses: github/codeql-action/analyze@6f2ac81f5cd81fe351a197ba0b00d91d03cd2aee # v4.39.0
         with:
           category: "/language:${{ matrix.language }}"
           # Drop the SARIF on disk so the gate step can read it. `upload` stays on

AGENTS.md

@@ -14,7 +14,8 @@ F# ahead of C# on every new feature. F# never takes the back seat.
 # Workflow
 
 - **Sub agents are illegal.** Delegate by spawning `pi` sessions — you are responsible for their output
-- **Plans (`docs/plans/`) are the backlog.** Work toward checking off their items; delete a plan once it is complete
+- **Plans (`docs/plans/`) are the backlog and GitHub issues is for problem tracking.** Work toward checking off their items; delete a plan once it is complete
+- **Closing a GitHub issue requires testing a released, published version** No closing issues as you fix the bug
 - ⛔️ **Never attribute a commit to yourself**: no `Co-Authored-By`, no agent name. *Never overridable*
 - **Coordinate with other agents** through Too Many Cooks or built-in messaging: lock the files you edit, and never edit a file another agent has locked
 - **Never kill VS Code processes** — desktop or browser. They belong to the user
@@ -28,6 +29,7 @@ F# ahead of C# on every new feature. F# never takes the back seat.
 - **No SharpLsp code is "legacy".** Code that doesn't match the specs is deleted, never copied — move files, don't duplicate them
 - **All screens must be 100% reactive** to data changes. Manage state with Signals in the VSIX and other extensions
 - **Zero code duplication.** Run Deslop (see *Duplication*) before adding code and after editing
+- **Minimize GitHub spend** Check that action usage isn't unnecessarily spending money
 - **Paths are handled in *one* place per tier** — [SHARPLSP-ARCHITECTURE-PATHS]. Every path-string operation
   (normalise, compare, key, case rule, resolve, split, extension test, URI conversion) lives only in that
   tier's path module: `SharpLsp.Sidecar.Common.NativePaths` (sidecars), `src/sharplsp/src/paths.rs` (host),
@@ -64,9 +66,8 @@ F# ahead of C# on every new feature. F# never takes the back seat.
 
 - Run clippy and fmt routinely; fix violations immediately
 - All lints at highest strictness (Cargo.toml `[lints]`)
-- **`unsafe` is forbidden** (`unsafe_code = "deny"`)
-- **`unwrap()` is always a violation** — use `?` with proper error types
-- **No `panic!`, `todo!`, `unimplemented!`** — return `Result<T,E>`
+- **`unsafe`, `unwrap()` is forbidden** (`unsafe_code = "deny"`)
+- **No `panic!`, `todo!`, `unimplemented!`** — return `Result<T,E>` and use `?`
 
 ## .NET Sidecar Quality Standards
 
@@ -106,7 +107,7 @@ F# ahead of C# on every new feature. F# never takes the back seat.
 
 # Git
 
-> ⛔️ **Don't make git changes like creating new branches** unless the user asks or a skill demands it.
+> ⛔️ **Don't make git changes like creating new branches or worktrees** unless the user asks or a skill demands it.
 - Commit and push to submodules before commiting and pushing the feature branch
 - Commit and push after each major change
 - **One feature branch**, never `git worktree`. Work the open one; several open → merge them immediately