Repository navigation
Prove a .NET Framework run by the code the program wrote - #423
Closed
MelbourneDeveloper wants to merge 1 commit into
Closed
MelbourneDeveloper wants to merge 1 commit into
MelbourneDeveloper wants to merge 1 commit into
Conversation
…e code the pty reported VS Code's terminal process fires exitCode || 0, and on Windows node-pty can close conout before ConPTY hands over the exit code, so a run that returned 50 was reported as 0. Each fixture program now writes its code beside its binary; the test asserts that code exactly, and that the one task exit is that code or the pty's lost 0, which these programs never return.
MelbourneDeveloper
enabled auto-merge (squash)
October 21, 2026 06:23
auto-merge was automatically disabled
October 21, 2026 06:24
Pull request was closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TLDR
Fixes the flaky Windows
netfx-languageleg: a .NET Framework run that returned 50 was reported by VS Code as exit 0.Details
exitCode || 0. On Windows, node-pty can close conout before ConPTY hands over the exit code, soonDidEndTaskProcessreports 0. It happened in "a project built for .NET Framework ALONE still RUNS" (netfx-run-fsharp.test.ts) on a loaded runner. The run took 7 s, as long as a real run, so it was the run's own exit and not another task's.writeConsoleinnetfx-msbuild-kit.ts) also writes its exit code toexit-code.txtbeside its binary.assertRanWithasserts:runFromdeletes the result file before each run, so a stale file cannot pass.How Do The Automated Tests Prove It Works?
netfx-run-fsharp.test.tscovers all three Run cases throughrunFrom: RunProbe on net48 (48), RunProbe on the newest .NET (10), and NetfxOnly on net462 with its profile arguments (50).writeConsolebuilds for net48 and net10.0. On net10.0, run withalpha beta, it exits 12 and writes12.tsc,eslintandprettierare clean.