Repository navigation
feat: generalize context omission to json - #71
Merged
Merged
Conversation
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The exported callback change breaks downstream source compatibility and lacks direct regression coverage.
Review effort: Balanced
Findings: 1
Open (2)
What changed in this PR
Generalizes context omission metadata so it can be shared beyond text-log modifiers.
Changes:
- Adds
context:"omit"tags to verbose registry fields. - Passes struct metadata to omission callbacks.
- Centralizes contextual text-log omission logic.
| File | Description |
|---|---|
thorlog/v3/registry.go |
Adds context omission tags. |
thorlog/v3/event.go |
Introduces reusable context omission handling. |
textlog.go |
Changes the formatter omission callback API. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
secDre4mer
force-pushed
the
feat/generalize-omit
branch
from
September 29, 2026 13:57
03d032d to
790d9de
Compare
gremat
requested changes
Sep 29, 2026
Instead of having omitincontext as textlog modifier, create its own struct tag to have it available for JSON as well.
secDre4mer
force-pushed
the
feat/generalize-omit
branch
from
September 30, 2026 07:16
790d9de to
f2baf34
Compare
gremat
approved these changes
Sep 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of having omitincontext as textlog modifier, create its own struct tag to have it available for JSON as well.