Skip to content

fix(activitypub): validate nodeinfo redirect host and scheme before fetching #111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
prasanna8585 wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

fix(activitypub): validate nodeinfo redirect host and scheme before fetching #111

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions validator/activitypub/activitypub.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import (
"encoding/json"
"fmt"
"net/http"
"net/url"
"regexp"
"strings"

Expand Down Expand Up @@ -101,6 +102,22 @@ func (ap *ActivityPub) DetectServerSoftware() (server ServerSoftware, err error)
if link.Rel != "http://nodeinfo.diaspora.software/ns/schema/2.0" {
continue
}
parsedHref, err := url.Parse(link.Href)
if err != nil {
return "", e(xerrors.Errorf("invalid nodeinfo link href: %w", err))
}
if parsedHref.Scheme != "https" {
return "", xerrors.Errorf(
"nodeinfo link scheme mismatch: got %s, expected https",
parsedHref.Scheme,
)
}
if parsedHref.Hostname() != serverURL {
return "", xerrors.Errorf(
"nodeinfo link host mismatch: got %s, expected %s",
parsedHref.Hostname(), serverURL,
)
}
resp, err := http.Get(link.Href)
if err != nil {
return "", e(err)
Expand Down
Loading