Skip to content

Manually made changes to fix oidc auth block issues with 20.0.4 #1499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
briankalwat wants to merge 1 commit into
base: beta
Choose a base branch
from
Open

Manually made changes to fix oidc auth block issues with 20.0.4 #1499

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion RockWeb/Blocks/Security/Oidc/Authorize.ascx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
<div style="max-width: 360px; margin-left: auto; margin-right: auto;">
<div class="card">
<div class="card-body" style="display: flex; flex-direction: column; gap: var(--spacing-medium); padding: var(--spacing-large);">
<h3 style="text-align: center;">Claude</h3>
<h3 style="text-align: center;">Authorization</h3>

<p style="text-align: center;">
<strong><asp:Literal ID="lNickName" runat="server" />, <asp:Literal ID="lClientName" runat="server" /> is requesting access to your account.</strong>
Expand Down
11 changes: 11 additions & 0 deletions RockWeb/Blocks/Security/Oidc/Authorize.ascx.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -421,6 +421,17 @@ private void AcceptAuthorization()
return;
}

// The "openid" scope not a traditional scope. It is used by the
// OpenID Connect provider to indicate that the client is
// requesting an id_token. Therefore it is safe to add it to the
// list of allowed scopes if it was requested without checking if
// the client is allowed to request it via the
// NarrowRequestedScopesToApprovedScopes() method.
if ( requestedScopes.Contains( "openid" ) )
{
clientAllowedScopes.Add( "openid" );
}

// Create a new ClaimsIdentity containing the claims that
// will be used to create an id_token, a token or a code.
var identity = RockIdentityHelper.GetRockClaimsIdentity( CurrentUser, clientAllowedClaims, authClient.ClientId );
Expand Down