Repository navigation
Conversation
…nd task level meta is an opaque JSON object (at most 16 KB each) that Ringer copies into the run state untouched, so outside tools such as Referee can link a work order to the OpenSpec change, task, and scenarios it came from. state_version lets those readers refuse a format they do not know. Co-Authored-By: Claude Opus 5.5 <[email protected]>
boydwold
force-pushed
the
referee/state-version-meta
branch
from
October 9, 2026 00:04
0912cb6 to
9c4b324
Compare
with_max_parallel built a new Manifest field by field and left out meta, so ringer.py run --max-parallel N lost the run-level meta. It now uses dataclasses.replace, which keeps every field. Found by a plan review. Co-Authored-By: Claude Opus 5.5 <[email protected]>
Author
|
I added a fix that a review found. The new test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tools outside Ringer that read
~/.ringer/runs/<run_id>.jsonhave two gaps today:This PR adds two small, opt-in parts of one contract for readers of the run state:
state_versionin the run state (now1). A reader can refuse a version it does not know. The constant's comment says to bump it whenever a field that readers use changes meaning or shape.metain the manifest, at run level and per task: an optional JSON object that Ringer copies into the run state untouched (metaon the run and on each task). Ringer never reads it. Each is capped at 16 KB, so a manifest cannot bloat the state file. A non-object or an oversizedmetais a manifest error with a clear message.Backward compatible:
metais optional and shows asnullwhen absent, and manifests without it run as before.Proof:
tests/test_state_meta.py(13 tests) covers parsing, the size cap, the copy,Manifest.from_path, the snapshot, and the written file. The full suite passes locally on Linux, excepttest_hud_single_tab.test_dead_then_alive_opens_once_after_spawn, which also fails on currentmainwithout this change. The README manifest table documents both fields, and the Contributors section has the credit line thattest_contributorsrequires.Happy to split this into two PRs (
state_version, thenmeta) if you prefer.