Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description and Purpose
When 1P+2P IPC is enabled, the yaw PI controller reads
axisYawF_2P, but the Colemantransform only updates
axisYaw_2P. Update the PI feedback on every timestep so the2P yaw pitch contribution responds to the measured blade moments.
Type of change
Examples/Testing
Built baseline and corrected controller DLLs with GNU Fortran 13.2.0 and ran four
OpenFAST 5.0.0 simulations of the bundled NREL 5MW onshore model: proportional-only
and integral-only 2P IPC, each before and after the one-line correction. All runs
complete 60 seconds. The baseline's 2P yaw feedback/output remain zero despite
nonzero moments; the correction restores feedback and changes actual blade pitch.