V26.2.0-IOFreeze: new Absorptance Inside Face fields by joseph-robertson · Pull Request #5648 · NatLabRockies/OpenStudio

joseph-robertson · 2026-09-01T18:27:29Z

Pull request overview

Wraps Implementation of Fixed and Variable Absorptances at the Inside Face of Materials EnergyPlus#11750

Pull Request Author

Model API Changes / Additions
Any new or modified fields have been implemented in the EnergyPlus ForwardTranslator (and ReverseTranslator as appropriate)
Model API methods are tested (in src/model/test)
EnergyPlus ForwardTranslator Tests (in src/energyplus/Test)
If a new object or method, added a test in NREL/OpenStudio-resources: Add Link
If needed, added VersionTranslation rules for the objects (src/osversion/VersionTranslator.cpp)
Verified that C# bindings built fine on Windows, partial classes used as needed, etc.
All new and existing tests passes
If methods have been deprecated, update rest of code to use the new methods

Labels:

If change to an IDD file, add the label IDDChange
If breaking existing API, add the label APIChange
If deemed ready, add label Pull Request - Ready for CI so that CI builds your PR

Review Checklist

This will not be exhaustively relevant to every PR.

Perform a Code Review on GitHub
Code Style, strip trailing whitespace, etc.
All related changes have been implemented: model changes, model tests, FT changes, FT tests, VersionTranslation, OS App
Labeling is ok
If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
If feature, test running new feature, try creative ways to break it
CI status: all green or justified

github-actions · 2026-09-01T18:28:03Z

🧪 Test Results Dashboard

Summary

Metric	Value
Total Tests	0
Passed	0
Failed	0
Errors	0
Skipped	0
Success Rate	0.0%
Generated	2026-09-04 10:05:44 UTC

❌ Significant Test Failures

📊 Test Run Information

Run	XML File	Status
-	No XML files found	❌ Missing

Copilot

🟡 Changes recommended

The blank Material:NoMass reverse-translation test uses incorrect field indices, invalidating its fallback assertions.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

Adds inside-face absorptance support for standard and massless opaque materials, including blank-value inheritance and EnergyPlus translation.

Changes:

Extends the model schema and APIs with three inside-face absorptance fields.
Adds forward and reverse translation support.
Adds model and translator tests.

File summaries

File	Description
`resources/model/OpenStudio.idd`	Defines the optional fields.
`src/model/StandardOpaqueMaterial.hpp`	Exposes the standard-material API.
`src/model/StandardOpaqueMaterial_Impl.hpp`	Declares implementation methods.
`src/model/StandardOpaqueMaterial.cpp`	Implements fallback and mutation behavior.
`src/model/MasslessOpaqueMaterial.hpp`	Exposes the massless-material API.
`src/model/MasslessOpaqueMaterial_Impl.hpp`	Declares implementation methods.
`src/model/MasslessOpaqueMaterial.cpp`	Implements fallback and mutation behavior.
`src/model/test/StandardOpaqueMaterial_GTest.cpp`	Tests standard-material behavior.
`src/model/test/MasslessOpaqueMaterial_GTest.cpp`	Tests massless-material behavior.
`src/energyplus/ForwardTranslator/ForwardTranslateStandardOpaqueMaterial.cpp`	Writes explicit standard-material values.
`src/energyplus/ForwardTranslator/ForwardTranslateMasslessOpaqueMaterial.cpp`	Writes explicit massless-material values.
`src/energyplus/ReverseTranslator/ReverseTranslateMaterial.cpp`	Imports standard-material values.
`src/energyplus/ReverseTranslator/ReverseTranslateMaterialNoMass.cpp`	Imports massless-material values.
`src/energyplus/Test/ForwardTranslator_GTest.cpp`	Tests omission and emission behavior.
`src/energyplus/Test/ReverseTranslator_GTest.cpp`	Tests imports and blank-field fallback.

Review details

Files reviewed: 15/15 changed files
Comments generated: 1
Review effort level: Balanced

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

joseph-robertson · 2026-09-02T16:24:22Z

NatLabRockies/EnergyPlus#11750 adds new output variables:

Surface Thermal Absorptance
Surface Solar Absorptance
Surface Thermal Absorptance Outside Face
Surface Solar Absorptance Outside Face
Surface Thermal Absorptance Inside Face
Surface Solar Absorptance Inside Face

But I'm not sure whether these should be added to any outputVariableNames; Surface.cpp contains only "Surface Inside Face Temperature" and "Surface Outside Face Temperature" while there are several more existing output variables that could be listed?

jmarrec · 2026-09-04T09:12:44Z

But I'm not sure whether these should be added to any outputVariableNames; Surface.cpp contains only "Surface Inside Face Temperature" and "Surface Outside Face Temperature" while there are several more existing output variables that could be listed?

Please do. I blamed, the Surface_Impl::outputVariableNames hasn't been touched since the first git commit 13 years ago. Just add all output variables for Surface in there

Edit: done in b0a5595 Add full outputVariableNames for Surface/SubSurface

jmarrec

LGTM!

jmarrec · 2026-09-04T10:06:15Z

+  N8,  \field Thermal Absorptance Inside Face
+       \note When blank, this value is equal to the Thermal Absorptance field above.
+       \note When entered, the Thermal Absorptance field applies to the outside face and this field applies to the inside face.
+       \type real
+       \minimum> 0
+       \maximum 0.99999
+  N9,  \field Solar Absorptance Inside Face
+       \note When blank, this value is equal to the Solar Absorptance field above.
+       \note When entered, the Solar Absorptance field applies to the outside face and this field applies to the inside face.
+       \type real
+       \minimum 0
+       \maximum 1
+  N10; \field Visible Absorptance Inside Face
+       \note When blank, this value is equal to the Visible Absorptance field above.
+       \note When entered, the Visible Absorptance field applies to the outside face and this field applies to the inside face.
+       \type real
+       \minimum 0
+       \maximum 1


Ok, truly optional. and No VT needed

jmarrec · 2026-09-04T10:08:22Z

+    double thermalAbsorptanceInsideFace() const;
+
+    bool isThermalAbsorptanceInsideFaceDefaulted() const;


Ok, so I'm guessing you went with if blank, grab the (regular) thermalAbsorptance field?

jmarrec · 2026-09-04T10:09:48Z

+    double StandardOpaqueMaterial_Impl::thermalAbsorptanceInsideFace() const {
+      if (boost::optional<double> value = getDouble(OS_MaterialFields::ThermalAbsorptanceInsideFace)) {
+        return value.get();
+      }
+      return thermalAbsorptance();
+    }
+
+    bool StandardOpaqueMaterial_Impl::isThermalAbsorptanceInsideFaceDefaulted() const {
+      return isEmpty(OS_MaterialFields::ThermalAbsorptanceInsideFace);
+    }


Right, yeah. I guess that's indeed a valid choice of implementation.

The other one being just provide an boost::optional<double> getter, setter and resetter.

jmarrec · 2026-09-04T10:10:35Z

+    // Inside-face absorptance fields have no IDD default and inherit the exterior value when blank.
+    if (!modelObject.isThermalAbsorptanceInsideFaceDefaulted()) {
+      idfObject.setDouble(openstudio::MaterialFields::ThermalAbsorptanceInsideFace, modelObject.thermalAbsorptanceInsideFace());
+    }


Right, only write it if it's explicitly set, makes sense

jmarrec · 2026-09-04T10:11:48Z

    const std::vector<std::string>& Surface_Impl::outputVariableNames() const {
-      static const std::vector<std::string> result{"Surface Inside Face Temperature", "Surface Outside Face Temperature"};
+      static const std::vector<std::string> result{
+        // Face temperatures and convection
+        "Surface Inside Face Temperature",
+        "Surface Inside Face Interior Movable Insulation Temperature",
+        "Surface Outside Face Temperature",
+        "Surface Inside Face Adjacent Air Temperature",
+        "Surface Inside Face Convection Heat Transfer Coefficient",
+        "Surface Inside Face Convection Heat Gain Rate",
+        "Surface Inside Face Convection Heat Gain Rate per Area",


I added 98 output Variables for Surface, 169 for SubSurfaces. From the E+ source code itself.

Note: Noticed the I/O ref is out of date, filled NatLabRockies/EnergyPlus#11783 (comment)

I don't see the following included in your add:

Surface Thermal Absorptance Outside Face

Surface Solar Absorptance Outside Face

Surface Thermal Absorptance Inside Face

Surface Solar Absorptance Inside Face

Is that intentional?

Is that from the c++ source code or the I/O reference?

(The I/O reference is quite outdated as I said)

It's new stuff in the E+ v26.2 IOFreeze.

jmarrec · 2026-09-04T10:14:33Z

Just going to let CI take a run on it to make sure my Surface/SubSurface edits are ok.

@joseph-robertson if you come around to this PR before me and Full Build is happy, go ahead and merge!

joseph-robertson added 5 commits September 1, 2026 11:07

Update the idd with new absorptance inside face fields.

fbbf3e6

Add absorptance inside face setters and getters.

b2217d7

Update ft and rt for the new absorpance inside face fields.

47fb94c

Add model, ft, and rt tests.

d495945

Test refinements for ft and rt.

8d06109

joseph-robertson self-assigned this Sep 1, 2026

joseph-robertson added Pull Request - Ready for CI This pull request if finalized and is ready for continuous integration verification prior to merge. IDDChange labels Sep 1, 2026

joseph-robertson added 2 commits September 1, 2026 12:42

Typos in new massless material model test.

b18d89a

Few more updates in new RT test.

cf3c26c

joseph-robertson requested a balanced review from Copilot September 1, 2026 21:47

joseph-robertson marked this pull request as ready for review September 1, 2026 21:47

Copilot started reviewing on behalf of joseph-robertson September 1, 2026 21:49 View session

Copilot AI reviewed Sep 1, 2026

View reviewed changes

Comment thread src/energyplus/Test/ReverseTranslator_GTest.cpp Outdated

Fix field index typos in new rt test.

07f0d96

joseph-robertson requested a review from jmarrec September 2, 2026 16:43

Add full outputVariableNames for Surface/SubSurface

b0a5595

jmarrec approved these changes Sep 4, 2026

View reviewed changes

jmarrec merged commit 29ea277 into develop Sep 4, 2026
6 of 7 checks passed

jmarrec deleted the v26.2.0-IOFreeze-InsideFaceAbs branch September 4, 2026 11:18

		double thermalAbsorptanceInsideFace() const;

		bool isThermalAbsorptanceInsideFaceDefaulted() const;

Uh oh!

Conversation

joseph-robertson commented Sep 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull request overview

Pull Request Author

Review Checklist

Uh oh!

github-actions Bot commented Sep 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🧪 Test Results Dashboard

Summary

❌ Significant Test Failures

📊 Test Run Information

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Uh oh!

Uh oh!

joseph-robertson commented Sep 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jmarrec commented Sep 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jmarrec left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jmarrec commented Sep 4, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

joseph-robertson commented Sep 1, 2026 •

edited

Loading

github-actions Bot commented Sep 1, 2026 •

edited

Loading

joseph-robertson commented Sep 2, 2026 •

edited

Loading

jmarrec commented Sep 4, 2026 •

edited

Loading