Take Kotlin 2.4.20, Gradle 9.7.1 and the rest of the group - #158
Merged
Conversation
Dependabot's #155, applied by hand rather than merged, because its branch predates #156 and its gradle/libs.versions.toml is the file from before the MCP module existed. Taking it wholesale removed the mcp-sdk, kotlinx-io and kotlin-logging entries and broke the build, which is how this was noticed: a dependency bump that reverts a catalog is not a dependency bump. Kotlin 2.4.20 needed no source change, with allWarningsAsErrors on and nine native targets. It does change the public API dump by one line: KdrantException.RateLimited gains an explicit no-argument constructor where 2.4.10 emitted only the synthetic one. Additive to the ABI, and worth naming because somebody reading that diff will look for the source change behind it and there isn't one. Both native binaries link and both proof scripts pass against a real Qdrant 1.19.1 under the new compiler: the CLI runs every subcommand, and an MCP client initializes, lists the tools and completes a search.
|
This pull request adds no capability the code did not already have. 4 files read · 1063 ms · against |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #155. Close that one rather than merging it.
Why it is applied by hand
Dependabot opened #155 against a main that predates #156, so its
gradle/libs.versions.tomlis the filefrom before the MCP module existed. Merging it would have removed the
mcp-sdk,kotlinx-io-coreandkotlin-loggingentries. That is how it was caught: the build failed on three unresolved catalogaccessors, which is the right failure but not an obvious one to read.
Only the version changes are taken here: Kotlin 2.4.10 to 2.4.20 across the three plugins and
kotlin-test, the Gradle wrapper 9.7.0 to 9.7.1, langchain4j 1.19.0 to 1.20.0, and the GraalVM buildtools 1.1.11 to 1.1.12.
The one thing that is not just a number
Kotlin 2.4.20 needs no source change, with
allWarningsAsErrorson and nine native targets. It doeschange the public API dump by one line:
RateLimitedhas two defaulted parameters, and 2.4.20 emits the explicit no-argument constructor where2.4.10 left only the synthetic bridge. It is additive to the ABI and there is no source change behind it,
which is worth saying because the dump is the file somebody checks when they want to know what moved.
Verification
./gradlew buildgreen,koverVerifyincluded. Both native binaries link under the new compiler, andboth proof scripts pass against a real Qdrant 1.19.1 on loopback: the CLI runs every subcommand, and an
MCP client initializes, lists the tools and completes a search.