Skip to content

Add ONNX Max and Min operators - #7

Merged
Toni-SM merged 1 commit into
NVIDIA:developfrom
han-xudong:feat/onnx-tanh-min-max
Sep 8, 2026
Merged

Toni-SM merged 1 commit into
NVIDIA:developfrom
han-xudong:feat/onnx-tanh-min-max

Conversation

@han-xudong

@han-xudong han-xudong commented Aug 12, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • add variadic Max and Min with multidirectional broadcasting for rank-0, rank-1, and rank-2 policy tensors producing rank-2 outputs
  • preserve gradient propagation and allocation-free CUDA graph replay through preallocated intermediate buffers
  • document the newly supported operators

The branch is rebased onto the develop version that includes #8, and the duplicate Tanh implementation has been removed.

Testing

  • .venv/bin/python -m pytest tests/runtime/test_onnx_runtime.py -q (14 passed)
  • uvx pre-commit run -a

Closes #6

@Toni-SM

Toni-SM commented Sep 3, 2026 •

Copy link
Copy Markdown
Collaborator

Hi @han-xudong

Could you please rebase and solve merge conflicts?
Also, please note that Than operator was added in #8.

@han-xudong han-xudong changed the title Add ONNX Tanh, Max, and Min operators Add ONNX Max and Min operators Sep 8, 2026
@han-xudong
han-xudong force-pushed the feat/onnx-tanh-min-max branch from 2412f13 to a75ec47 Compare September 8, 2026 02:11
@han-xudong

Copy link
Copy Markdown
Contributor Author

@Toni-SM Thank you for the guidance. I rebased the branch onto the latest develop and resolved the conflicts with #8. I removed the duplicate Tanh implementation and narrowed both #6 and this PR to the remaining variadic Max and Min support. The complete ONNX runtime test file passes (14 tests), and all pre-commit checks pass.

@Toni-SM
Toni-SM merged commit 3fcc8a4 into NVIDIA:develop Sep 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Max and Min support to ONNX runtime

2 participants