Skip to content

fix(self-managed): pin sis chart 2.6.0 for icms 0.8.3 - #2182

Merged
shobham-nv merged 1 commit into
mainfrom
shobham/bump-sis-2.6.0
Sep 30, 2026
Merged

shobham-nv merged 1 commit into
mainfrom
shobham/bump-sis-2.6.0

Conversation

@shobham-nv

@shobham-nv shobham-nv commented Sep 30, 2026 •

Copy link
Copy Markdown
Contributor

TL;DR

Pin the stack's sis release to chart 2.6.0, the chart released from #2178. It runs icms 0.8.3, which includes #2175, so under HA icms creates CreateNvcaFunctionTaskStream and TerminateNvcaStream with 3 replicas (and raises existing streams to 3).

Additional Details

For the Reviewer

One-line pin change in helmfile.d/02-core.yaml.gotmpl.

For QA

  • make -C deploy/stacks/self-managed test passes.
  • On an HA install (3 NATS servers), both of these should print 3:
    • nats stream info CreateNvcaFunctionTaskStream --json | jq '.config.num_replicas'
    • nats stream info TerminateNvcaStream --json | jq '.config.num_replicas'

Issues

Relates to #2052

Checklist

  • I am familiar with the Contributing Guidelines.
  • I have signed off my commits for Developer Certificate of Origin (DCO) compliance.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

Summary by CodeRabbit

  • Updates
    • Updated the SIS release to version 2.6.0.

sis chart 2.6.0 runs icms 0.8.3, which creates the NVCA NATS streams with the HA replica count (#2175).

Signed-off-by: shobham <[email protected]>
@shobham-nv
shobham-nv requested a review from a team as a code owner September 30, 2026 12:25
@coderabbitai

coderabbitai Bot commented Sep 30, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: NVIDIA/nvcf/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 93723335-04e3-4dc4-bd5b-53227b93de63

📥 Commits

Reviewing files that changed from the base of the PR and between 8cae96b and d26ad26.

📒 Files selected for processing (1)
  • deploy/stacks/self-managed/helmfile.d/02-core.yaml.gotmpl

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 11 remain after this review.


📝 Walkthrough

Walkthrough

The sis release chart version changes from 2.5.0 to 2.6.0.

Changes

SIS chart version update

Layer / File(s) Summary
Update SIS chart version
deploy/stacks/self-managed/helmfile.d/02-core.yaml.gotmpl
The sis release now uses chart version 2.6.0 instead of 2.5.0.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to d26ad

The chart update has no established merge-blocking defect. Confirming both NVCA streams use three replicas on a three-server HA installation remains a useful deployment validation.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title uses the required Conventional Commits format, includes the required scope for a fix, and accurately describes pinning the sis chart to version 2.6.0.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Comment @coderabbitai help to get the list of available commands.

@shobham-nv
shobham-nv added this pull request to the merge queue Sep 30, 2026
Merged via the queue into main with commit f5dff37 Sep 30, 2026
20 checks passed
@shobham-nv
shobham-nv deleted the shobham/bump-sis-2.6.0 branch September 30, 2026 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants