fix(self-managed): pin sis chart 2.6.0 for icms 0.8.3 - #2182
Conversation
sis chart 2.6.0 runs icms 0.8.3, which creates the NVCA NATS streams with the HA replica count (#2175). Signed-off-by: shobham <[email protected]>
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: NVIDIA/nvcf/.coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 11 remain after this review. 📝 WalkthroughWalkthroughThe ChangesSIS chart version update
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~3 minutes Change: Bug fix Merge Risk: ⚪ Minimal · up to The chart update has no established merge-blocking defect. Confirming both NVCA streams use three replicas on a three-server HA installation remains a useful deployment validation. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
TL;DR
Pin the stack's
sisrelease to chart 2.6.0, the chart released from #2178. It runs icms0.8.3, which includes #2175, so under HA icms createsCreateNvcaFunctionTaskStreamandTerminateNvcaStreamwith 3 replicas (and raises existing streams to 3).Additional Details
sischart 2.5.0 → 2.6.0. The only difference is the icms image,0.7.2→0.8.3.ICMS_NATS_REPLICAS(from fix(icms): create NVCA NATS streams with the HA replica count #2175), so no other stack change is needed.For the Reviewer
One-line pin change in
helmfile.d/02-core.yaml.gotmpl.For QA
make -C deploy/stacks/self-managed testpasses.3:nats stream info CreateNvcaFunctionTaskStream --json | jq '.config.num_replicas'nats stream info TerminateNvcaStream --json | jq '.config.num_replicas'Issues
Relates to #2052
Checklist
Summary by CodeRabbit