Skip to content

fix: _create_driver_package never builds nvidia-uvm.ko - #962

Open
andrewwhitecdw wants to merge 1 commit into
NVIDIA:mainfrom
andrewwhitecdw:bugfix/nvidia-driver-create-driver-package-never-builds
Open

fix: _create_driver_package never builds nvidia-uvm.ko#962
andrewwhitecdw wants to merge 1 commit into
NVIDIA:mainfrom
andrewwhitecdw:bugfix/nvidia-driver-create-driver-package-never-builds

Conversation

@andrewwhitecdw

Copy link
Copy Markdown

This PR addresses the following issue in rhel9/nvidia-driver: _create_driver_package never builds nvidia-uvm.ko.

Changes

  • rhel9/nvidia-driver: _create_driver_package never builds nvidia-uvm.ko.

Details

--- a/rhel9/nvidia-driver
+++ b/rhel9/nvidia-driver
@@ -1,1 +1,1 @@
-    make -s -j ${MAX_THREADS} SYSSRC=/lib/modules/${KERNEL_VERSION}/build nv-linux.o nv-modeset-linux.o > /dev/null
+    make -s -j ${MAX_THREADS} SYSSRC=/lib/modules/${KERNEL_VERSION}/build nv-linux.o nv-modeset-linux.o nvidia-uvm.ko > /dev/null

Tests

  • rhel9/test_create_driver_package.sh
--- /dev/null
+++ rhel9/test_create_driver_package.sh
@@ -0,0 +1,17 @@
+#!/bin/bash
+set -euo pipefail
+
+# Regression test: the _create_driver_package function must list nvidia-uvm.ko
+# as a make target because it is signed and packed later in the same function.
+func_body=$(sed -n '/^_create_driver_package()/,/^}/p' rhel9/nvidia-driver)
+make_line=$(printf '%s\n' "$func_body" | grep -E '^\s+make -s -j .* SYSSRC=')
+
+if [ -z "$make_line" ]; then
+    echo "FAIL: could not find the make invocation in _create_driver_package"
+    exit 1
+fi
+
+if printf '%s\n' "$make_line" | grep -q 'nvidia-uvm.ko'; then
+    echo "PASS: _create_driver_package builds nvidia-uvm.ko"
+else
+    echo "FAIL: _create_driver_package does not build nvidia-uvm.ko"
+    echo "Found: $make_line"
+    exit 1
+fi

Contributor guidelines

Per this repo's CONTRIBUTING.md:

  • All commits are signed off (Signed-off-by trailer, DCO).

@copy-pr-bot

copy-pr-bot Bot commented Aug 13, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant