Repository navigation
chore(viewport): cover generated keys for minimap roots without ids - #428
Merged
Merged
Conversation
Adds a unit test for automatic roots that have no id. Line coverage in minimap.ts rises from 97.24% to 100%, and branch coverage rises from 85.71% to 88.09%. No behavior change. Signed-off-by: Cursor Agent <[email protected]>
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
coryrylan
approved these changes
Oct 20, 2026
Collaborator
|
🎉 This issue has been resolved in version 2.2.11 🎉 |
Collaborator
|
🎉 This issue has been resolved in version 1.0.2 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task
Coverage. The selector chose
projects/viewport/src/minimap/minimap.ts.Rationale: "6 uncovered lines, 97.24% lines and 85.71% branches, the smallest gap below the 90% threshold"
Measurement
minimap.tsunit coverage:No other file's line or branch coverage decreased. Viewport unit tests: 327 passed.
API
No public API changed.
Left alone
Fifteen defensive branches remain uncovered: a missing viewport, a missing preview wrapper, zero-size roots, an undefined ResizeObserver, and a pointer session that no longer matches. Line coverage is complete, so the selector will not choose this file again for those branches.