Repository navigation
chore(core): drop redundant gauge axe type assertion - #420
Merged
Merged
Conversation
Removes the unnecessary Gauge array assertion in the accessibility fixture. querySelectorAll already returns Gauge elements from the tag map, so the suppression for this file is pruned. The repo-wide count for @typescript-eslint/no-unnecessary-type-assertion goes from 220 to 219. No behavior change. Signed-off-by: Cursor Agent <[email protected]>
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
coryrylan
approved these changes
Oct 20, 2026
Collaborator
|
🎉 This issue has been resolved in version 2.2.10 🎉 |
Collaborator
|
🎉 This issue has been resolved in version 1.0.2 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Selected task
Lint mode B. The selector chose
@typescript-eslint/no-unnecessary-type-assertioninprojects/core/src/gauge/gauge.test.axe.ts.Measurement
src/gauge/gauge.test.axe.ts, and 220 suppressions repo-wide.as Gauge[].querySelectorAll(Gauge.metadata.tag)already returnsGaugeelements.Public API
No public API changed.
gauge.tsis untouched.Left alone
projects/core/src/gauge/gauge.test.tsstill assertsas Gauge[]and keeps its own suppression. This run only clears the file the selector named.Validation
projects/corelint passed.pnpm run test: 2120 passed.pnpm run test:types: already fresh, skipped.pnpm run test:axe: 87 passed, includinggauge.test.axe.ts.pnpm run test:ssr: already fresh, skipped.pnpm run test:lighthouse: 80 passed.pnpm run test:visual: already fresh, skipped.CI=true pnpm run cipassed (4 ran, 181 skipped).git diff --checkpassed.@internals/testingdist moved aside.