Fix racecheck in parquet reader delta byte array kernels - #23898
Fix racecheck in parquet reader delta byte array kernels#23898davidwendt wants to merge 1 commit into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review. 📝 WalkthroughSummary by CodeRabbit
WalkthroughChangesThe Parquet CUDA delta decoders now add warp synchronization around shared state updates. String reconstruction paths snapshot prior string state before updating Parquet delta decoder synchronization
Estimated code review effort: 3 (Moderate) | ~20 minutes Merge Risk: ⚪ Minimal · up to This localized change adjusts synchronization in Parquet byte-array decoding to address reported race warnings; no actionable merge-blocking risk remains. Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 33.33% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 3 functions across 1 files. (1 skipped: 1 unsupported.)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Description
Fixes some racecheck warnings reported by compute-sanitizer in the weekly CI runs: https://github.com/NVIDIA/cudf/actions/runs/33247027974/job/99086397880#step:5:3314
Adds appropriate sync-warp to prevent the race condition.
Checklist