Repository navigation
fix(cutile): retain source origins for generated code and host checks - #1602
Conversation
Signed-off-by: Melih Elibol <[email protected]>
|
CI follow-up for the v0.5.0 candidate: the CUDA 13.2/13.4 Tile lanes, shared-host tests, and other functional checks passed, but The compatibility change is documented in the PR, but that does not satisfy the version gate. Before merging, this needs either the coordinated v0.5.0 shared-host crate version/dependency updates or an API-compatible representation. Keep the semver check enabled. Failure details: https://github.com/NVIDIA/cuda-rust/actions/runs/39655891846/job/119416778266 |
Signed-off-by: Melih Elibol <[email protected]>
|
Fixed the semver failure in 825de3e. Source frames now stay private to the compiler and are rendered into the existing Validation: host and Tile semver suites pass; the CPU/assembler suite, two new collection tests, all six source-location regressions, all nine debug-info tests (including live CUDA-GDB), and the GPU host-check enforcement regression pass. Strict Clippy, formatting, SPDX, and whitespace checks pass. All build/test/semver CI jobs have now passed on this commit, including CUDA 13.2/13.4 and shared-host/reactor checks. Rust CodeQL also passed (verified 2026-10-22); all applicable CI checks are green. Self-review completed:
|
Generated const-generic arrays and reduction bodies can point at the module header, and checks relocated to the host lose the original access and inline caller locations. Preserve those origins through compilation and show every distinct protected access when a shared launch check fails.
Part of #1475:
LaunchCheck.causediagnostic at export, through the same path forKernelCompilerand the runtime validator. The public shared-host API, crate versions, dependencies, and check-evaluation behavior are unchanged.Other claimed frontend work stays with #1385 (generated-constant fallback), #1480 (entry wrappers), and #1528 (short-circuit/folded expressions). This does not close the full audit. Actual assertion SIGTRAP/coredump attribution remains a Tile IR backend issue under #1379; caller-line breakpoint resolution belongs to NVIDIA/cuda-gdb#29 / #1476.
Validation on
825de3e38:LaunchCheckstruct literals remain valid.e027ac324).launch_checks_are_enforced_at_launchregression also passes.The earlier full-suite run on
89a3d688dpassed CPU checks, 27 examples (one capability skip), and eight benchmark smoke tests. The GPU suite encountered the existing warmup-cache ordering failure documented in #1480; all 16 warmup tests passed serially. Benchmark validation supplied--features smoke-testbecause the existing runner drops its baresmoke-testargument. No runner changes are included.Backend limitation: full-debug tileiras 13.3 coalesces one adjacent reduction source-line entry despite correct frontend metadata; all four call lines survive optimized line-info assembly. This change preserves frontend provenance and does not claim complete backend stepping accuracy.