Repository navigation
[TRTLLM-16770][feat] Support LiLiCorr draft checkpoints in DFlash #19856
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
eopXD
wants to merge
1
commit into
NVIDIA:main
Choose a base branch
from
eopXD:feat/lilicorr-dflash
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,132
−31
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Forcing
_is_dflash2 = Falsefor LiLiCorr has two side effects beyond skipping the selector:_validate_dflash2_config()is skipped, so a LiLiCorr checkpoint withconv_kernel_size > 0only gets theconv_group_sizecheck added inLiLiCorrForCausalLM.__init__.explicit_causalat line 1294 is only consulted when_is_dflash2is true, so a LiLiCorr checkpoint derived from a DFlash 2 drafter that sets top-levelis_causalsilently falls back to the layer-type default.If LiLiCorr checkpoints are always non-causal and never ship
is_causal, a one-line comment here saying so would prevent the next reader from re-deriving it. Otherwise consider keeping_is_dflash2as computed and gating only the selector load/use on_uses_lilicorr.