docs: bump stated Rust MSRV from 1.88 to 1.90#2276
Open
mesutoezdil wants to merge 3 commits into
Open
Conversation
mesutoezdil
requested review from
a team,
derekwaynecarr,
maxamillion and
mrunalp
as code owners
Collaborator
|
This looks good, but could you also update |
Contributor
Author
done |
Collaborator
|
/ok to test e0e4231 |
krishicks
previously approved these changes
Jul 16, 2026
Cargo.toml sets rust-version = "1.90" (rust-toolchain.toml pins 1.95.0), so building with the previously documented 1.88 fails Cargo's MSRV check.
examples/governance-interceptor/Cargo.toml still had rust-version 1.88. Also bump e2e/rust's prost dependency to 0.14 to match the workspace, since it was on 0.13 in an otherwise standalone crate.
mesutoezdil
force-pushed
the
fix/contributing-rust-msrv
branch
from
e0e4231 to
ee2bf07
Compare
Contributor
Author
|
Updated e2e/rust/Cargo.toml as requested. Also found examples/governance-interceptor/Cargo.toml had the same 1.88 vs 1.90 drift and fixed it, plus bumped e2e/rust's prost pin from 0.13 to 0.14 to match the workspace. |
Collaborator
|
/ok to test ee2bf07 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CONTRIBUTING.md lists Rust 1.88+ as a project requirement, but
Cargo.toml's[workspace.package] rust-versionis set to "1.90" (andrust-toolchain.tomlpins 1.95.0). Building with 1.88 or 1.89 fails Cargo's MSRV check. Updates the documented minimum to match.