chore(skills): refresh stale Relay signatures for 0.6#480
Conversation
Remove the two signature bundles that no longer match their skill content so NVSkills CI can regenerate content-aligned signatures without changing the underlying skills. Signed-off-by: Allan Enemark <[email protected]>
Reflow existing Markdown without changing rendered instructions so NVSkills CI detects both affected skills and can regenerate their stale signature bundles. Signed-off-by: Allan Enemark <[email protected]>
WalkthroughThe get-started and observability skill documentation, benchmark reports, skill cards, and Sigstore bundles were refreshed. Markdown wrapping-only changes were also made in two skill documents. ChangesGet-started skill refresh
Observability skill refresh
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested labels: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
github-actions
Bot
added
the
Maintenance
|
/nvskills-ci |
|
/nvskills-ci |
Signed-off-by: nvskills-svc-account <[email protected]>
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
skills/nemo-relay-get-started/skill-card.md (1)
1-2: 📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick winAdd SPDX headers to both Markdown files before regenerating signatures.
skills/nemo-relay-get-started/skill-card.md#L1-L2: add the repository-standard SPDX header before the first heading.skills/nemo-relay-get-started/BENCHMARK.md#L1-L3: add the same required header before# Evaluation Report.Because both files are signed resources, regenerate and reverify
skills/nemo-relay-get-started/skill.oms.sigafterward.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@skills/nemo-relay-get-started/skill-card.md` around lines 1 - 2, Add the repository-standard SPDX header before the first heading in skills/nemo-relay-get-started/skill-card.md lines 1-2 and before # Evaluation Report in skills/nemo-relay-get-started/BENCHMARK.md lines 1-3. Then regenerate and reverify the signed resource skills/nemo-relay-get-started/skill.oms.sig.Source: Coding guidelines
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@skills/nemo-relay-get-started/skill-card.md`:
- Around line 49-50: Fix Markdown spacing in skill-card.md by adding blank lines
after the Evaluation Tasks and Skill Version(s) headings, and apply the same
spacing correction to the additional locations identified by the reviewer before
their following content or tables.
In `@skills/nemo-relay-plugin-observability/BENCHMARK.md`:
- Line 66: Update the Tier 1 validation result text in BENCHMARK.md to use the
singular “check” when the count is 1, changing “Skill Evaluator ran 1 checks” to
“Skill Evaluator ran 1 check”.
In `@skills/nemo-relay-plugin-observability/skill-card.md`:
- Around line 34-47: Add the required blank lines around the affected Markdown
headings and the results table in the skill card, including after the headings
near the output, evaluation-agent, and evaluation-task sections and before the
table. Run the repository’s formatter on the changed file before the final
lint/test pass.
---
Outside diff comments:
In `@skills/nemo-relay-get-started/skill-card.md`:
- Around line 1-2: Add the repository-standard SPDX header before the first
heading in skills/nemo-relay-get-started/skill-card.md lines 1-2 and before #
Evaluation Report in skills/nemo-relay-get-started/BENCHMARK.md lines 1-3. Then
regenerate and reverify the signed resource
skills/nemo-relay-get-started/skill.oms.sig.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Enterprise
Run ID: bd742568-4eb6-4b77-81cc-22babdffb9f2
📒 Files selected for processing (6)
skills/nemo-relay-get-started/BENCHMARK.mdskills/nemo-relay-get-started/skill-card.mdskills/nemo-relay-get-started/skill.oms.sigskills/nemo-relay-plugin-observability/BENCHMARK.mdskills/nemo-relay-plugin-observability/skill-card.mdskills/nemo-relay-plugin-observability/skill.oms.sig
📜 Review details
🧰 Additional context used
📓 Path-based instructions (8)
**/*
📄 CodeRabbit inference engine (.agents/skills/validate-change/SKILL.md)
**/*: Format changed files with the language-native formatter before the final lint/test pass.
If dynamic plugin behavior changed, usemaintain-dynamic-pluginsand include the native SDK, worker protocol, Python SDK, docs, packaging, and Codecov surfaces in the validation plan.
If code changes alter APIs, bindings, commands, paths, packaging behavior, observability/adaptive semantics, or documented best practices, update any dependent maintainer or consumer skills in the same branch.
During iteration, preferuv run pre-commit run --files <changed files...>.
Before review or handoff, runuv run pre-commit run --all-files.
Files:
skills/nemo-relay-plugin-observability/skill.oms.sigskills/nemo-relay-get-started/BENCHMARK.mdskills/nemo-relay-plugin-observability/skill-card.mdskills/nemo-relay-get-started/skill-card.mdskills/nemo-relay-get-started/skill.oms.sigskills/nemo-relay-plugin-observability/BENCHMARK.md
**/*.{md,rst,html,txt}
📄 CodeRabbit inference engine (.agents/skills/review-doc-style/assets/nvidia-style-brand-terminology.md)
**/*.{md,rst,html,txt}: Always spellNVIDIAin all caps. Do not useNvidia,nvidia,nVidia,nVIDIA, orNV.
Usean NVIDIAbefore a noun because the name starts with an 'en' sound.
Do not add a registered trademark symbol afterNVIDIAwhen referring to the company.
Use trademark symbols with product names only when the document type or legal guidance requires them.
Verify official capitalization, spacing, and hyphenation for product names.
Precede NVIDIA product names withNVIDIAon first mention when it is natural and accurate.
Do not rewrite product names for grammar or title-case rules.
Preserve third-party product names according to the owner's spelling.
Include the company name and full model qualifier on first use when it helps identify the model.
Preserve the official capitalization and punctuation of model names.
Use shorter family names only after the full name is established.
Spell out a term on first use and put the acronym in parentheses unless the acronym is widely understood by the intended audience.
Use the acronym on later mentions after it has been defined.
For long documents, reintroduce the full term if readers might lose context.
Form plurals of acronyms withs, not an apostrophe, such asGPUs.
In headings, common acronyms can remain abbreviated. Spell out the term in the first or second sentence of the body.
Common terms such asCPU,GPU,PC,API, andUIusually do not need to be spelled out for developer audiences.
Files:
skills/nemo-relay-get-started/BENCHMARK.mdskills/nemo-relay-plugin-observability/skill-card.mdskills/nemo-relay-get-started/skill-card.mdskills/nemo-relay-plugin-observability/BENCHMARK.md
**/*.{md,rst,html}
📄 CodeRabbit inference engine (.agents/skills/review-doc-style/assets/nvidia-style-brand-terminology.md)
Link the first mention of a product name when the destination helps the reader.
Files:
skills/nemo-relay-get-started/BENCHMARK.mdskills/nemo-relay-plugin-observability/skill-card.mdskills/nemo-relay-get-started/skill-card.mdskills/nemo-relay-plugin-observability/BENCHMARK.md
**/*.{md,rst,txt}
📄 CodeRabbit inference engine (.agents/skills/review-doc-style/assets/nvidia-style-guide.md)
Spell
NVIDIAin all caps. Do not useNvidia,nvidia, orNV.
Files:
skills/nemo-relay-get-started/BENCHMARK.mdskills/nemo-relay-plugin-observability/skill-card.mdskills/nemo-relay-get-started/skill-card.mdskills/nemo-relay-plugin-observability/BENCHMARK.md
**/*.{md,rst}
📄 CodeRabbit inference engine (.agents/skills/review-doc-style/assets/nvidia-style-guide.md)
**/*.{md,rst}: Format commands, code elements, expressions, package names, file names, and paths as inline code.
Use descriptive link text. Avoid raw URLs and weak anchors such as "here" or "read more."
Use title case consistently for technical documentation headings.
Introduce code blocks, lists, tables, and images with complete sentences.
Write procedures as imperative steps. Keep steps parallel and split long procedures into smaller tasks.
Prefer active voice, present tense, short sentences, contractions, and plain English.
Usecanfor possibility and reservemayfor permission.
Useafterfor temporal relationships instead ofonce.
Preferrefer tooverseewhen the wording points readers to another resource.
Avoid culture-specific idioms, unnecessary Latinisms, jokes, and marketing exaggeration in technical docs.
Spell out months in body text, avoid ordinal dates, and use clear time zones.
Spell out whole numbers from zero through nine unless they are technical values, parameters, versions, or UI values.
Use numerals for 10 or greater and include commas in thousands.
Do not add trademark symbols to learning-oriented docs unless the source, platform, or legal guidance explicitly requires them.
Files:
skills/nemo-relay-get-started/BENCHMARK.mdskills/nemo-relay-plugin-observability/skill-card.mdskills/nemo-relay-get-started/skill-card.mdskills/nemo-relay-plugin-observability/BENCHMARK.md
**/*.md
📄 CodeRabbit inference engine (.agents/skills/review-doc-style/assets/nvidia-style-technical-docs.md)
**/*.md: Use title case consistently in technical documentation headings
Avoid quotation marks, ampersands, and exclamation marks in headings
Keep product, event, research, and whitepaper names in their official title case
Use title case for table headers
Do not force social-media sentence case into technical docs
Format code elements, commands, parameters, package names, and expressions in monospace
Format directories, file names, and paths in monospace using backticks
Use angle brackets inside monospace for variables inside paths, such as/home/<username>/.login
Format error messages and strings in quotation marks, keeping literal code strings in code formatting when clearer
Format UI buttons, menus, fields, and labels in bold
Use angle brackets between UI labels for menu paths, such as File > Save As
Use italics for new terms on first use, sparingly and only when introducing the term
Use italics for publication titles
Format keyboard shortcuts in plain text, such as Press Ctrl+Alt+Delete
Use owner/repo link text for GitHub repositories, preferring[NVIDIA/NeMo](link)over prose references like 'the GitHub repo'
Introduce every code block with a complete sentence
Do not make a code block complete the grammar of the previous sentence
Do not continue a sentence after a code block
Use syntax highlighting when the format supports it for code blocks
Avoid the word 'snippet' unless the surrounding docs already use it as a term of art
Keep inline method, function, and class references consistent with nearby docs, omitting empty parentheses for prose readability when no call is shown
Use descriptive anchor text that matches the destination title when possible for links
Avoid raw URLs in running text
Avoid generic anchor text such as 'here,' 'this page,' and 'read more'
Include acronyms in link text when a linked term includes an acronym
Do not link long sentences or multiple sentences
Avoid links that pull readers away from a procedure unless the link is a p...
Files:
skills/nemo-relay-get-started/BENCHMARK.mdskills/nemo-relay-plugin-observability/skill-card.mdskills/nemo-relay-get-started/skill-card.mdskills/nemo-relay-plugin-observability/BENCHMARK.md
**/*.{md,mdx}
📄 CodeRabbit inference engine (AGENTS.md)
Update
README.md,fern/, package READMEs, and binding-support notes when public behavior, package names, examples, or supported bindings change.
**/*.{md,mdx}: Prefer the documented public API, not internal shortcuts
Keep package names, repo references, and build commands current
Keep release-process and release-notes guidance in repo-maintainer docs such asRELEASING.md, not as user-facing docs pages orCHANGELOG.md
Keep stable user-facing wrappers atscripts/root in docs and examples; only point at namespaced helper paths when documenting internal maintenance work
When detailed dynamic plugin guides exist, keep Rust native plugin examples, Python worker plugin examples, andgrpc-v1protocol details on separate pagesIf links in documentation change, run
just docs-linkcheck.
Files:
skills/nemo-relay-get-started/BENCHMARK.mdskills/nemo-relay-plugin-observability/skill-card.mdskills/nemo-relay-get-started/skill-card.mdskills/nemo-relay-plugin-observability/BENCHMARK.md
**/*.{md,markdown,mdx}
📄 CodeRabbit inference engine (CONTRIBUTING.md)
Add the SPDX license header to all Markdown/MDX documentation files using the HTML comment block form.
Files:
skills/nemo-relay-get-started/BENCHMARK.mdskills/nemo-relay-plugin-observability/skill-card.mdskills/nemo-relay-get-started/skill-card.mdskills/nemo-relay-plugin-observability/BENCHMARK.md
🪛 markdownlint-cli2 (0.23.0)
skills/nemo-relay-plugin-observability/skill-card.md
[warning] 34-34: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below
(MD022, blanks-around-headings)
[warning] 40-40: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below
(MD022, blanks-around-headings)
[warning] 46-46: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below
(MD022, blanks-around-headings)
[warning] 68-68: Tables should be surrounded by blank lines
(MD058, blanks-around-tables)
[warning] 76-76: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below
(MD022, blanks-around-headings)
skills/nemo-relay-get-started/skill-card.md
[warning] 49-49: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below
(MD022, blanks-around-headings)
[warning] 71-71: Tables should be surrounded by blank lines
(MD058, blanks-around-tables)
[warning] 79-79: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below
(MD022, blanks-around-headings)
🔇 Additional comments (11)
skills/nemo-relay-get-started/skill-card.md (2)
12-12: LGTM!
32-34: 📐 Maintainability & Code QualityRun the documentation link check for the changed references.
The documentation links changed in this segment; run
just docs-linkcheckbefore merge.Source: Coding guidelines
skills/nemo-relay-get-started/BENCHMARK.md (3)
3-21: LGTM!
23-41: LGTM!
54-60: LGTM!Also applies to: 80-80
skills/nemo-relay-get-started/skill.oms.sig (1)
1-1: 🗄️ Data Integrity & IntegrationNo action needed. The signed resource digests match the checked-in files.
skills/nemo-relay-plugin-observability/skill-card.md (3)
12-12: LGTM!
28-31: LGTM!
35-38: LGTM!Also applies to: 41-42, 47-47, 70-74, 77-77
skills/nemo-relay-plugin-observability/BENCHMARK.md (1)
3-21: LGTM!Also applies to: 35-40, 54-65, 80-80
skills/nemo-relay-plugin-observability/skill.oms.sig (1)
1-1: 🗄️ Data Integrity & IntegrationConfirm the embedded resource hashes
The bundle records SHA-256 digests forBENCHMARK.md,SKILL.md,evals/evals.json,references/atif.md,references/atof.md,references/openinference.md,references/opentelemetry.md, andskill-card.md; these should be checked against the checked-in files before merging.
|
/ok to test e64eb68 |
3 participants
Overview
Refresh two stale NeMo Relay skill signatures that are blocking publication through the NVIDIA skills catalog sync. This clean retry supersedes #469 after infrastructure issues made that PR's validation history and generated artifacts unreliable.
Details
release/0.6branch directly.skill.oms.sigbundle fromnemo-relay-get-started.skill.oms.sigbundle fromnemo-relay-plugin-observability.SKILL.mdwithout changing rendered instructions, ensuring NVCARPS includes both skills in its signing input set.Do not merge until the
Attach NVSkills validation signaturesbot commit lands, both affected skills pass content-integrity verification, and the generated benchmarks contain numeric Tier 3 results rather than all-N/Atables.Where should the reviewer start?
Start with the two deleted signature bundles and the rendered-content-neutral Markdown reflows. NVSkills CI should restore each bundle with digests matching the current
release/0.6skill content.Validation before opening:
release/0.6tip.SKILL.mdfiles and two deleted stale signature bundles.[email protected].git diff --check upstream/release/0.6...HEADRelated Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)
Summary by CodeRabbit
Documentation
Chores