[26.04_linux-nvidia] watchdog: sbsa_gwdt: add early_enable module parameter - #557
[26.04_linux-nvidia] watchdog: sbsa_gwdt: add early_enable module parameter#557kbutala-nv wants to merge 1 commit into
Conversation
kbutala-nv
changed the title
BaseOS Kernel ReviewWarning
|
PR Validation ReportPatchscan ✅ No Missing FixesAll cherry-picked commits checked — no missing upstream fixes found. PR Lint ❌ Errors foundDetailsChecking 1 commits...
Cherry-pick digest:
┌──────────────┬──────────────────────────────────────────────────────────────────┬────────────┬─────────┬───────────────────────────┐
│ Local │ Referenced upstream / Patch subject │ Patch-ID │ Subject │ SoB chain │
├──────────────┼──────────────────────────────────────────────────────────────────┼────────────┼─────────┼───────────────────────────┤
│ 93bda09ac4ae │ [SAUCE] watchdog: sbsa_gwdt: add early_enable module parameter │ N/A │ N/A │ wang, linux, kbutala │
└──────────────┴──────────────────────────────────────────────────────────────────┴────────────┴─────────┴───────────────────────────┘
Lint results:
E: 93bda09ac4ae ("watchdog: sbsa_gwdt: add early_enable module param"): not SAUCE/UBUNTU/Revert but has no upstream reference trailer (cherry picked from commit ... or backported from ...)
PR metadata:
E: PR targets 26.04_linux-nvidia but body has no https://bugs.launchpad.net/... link
|
8e3dc4e to
87b8b4e
Compare
|
@kbutala-nv LGTM The commit is merged in watchdog-next so "NVIDIA: SAUCE" is not needed. |
Ack! I thought the linter is failing because of that. Should I remove it from PR description or commit message (or both)? |
|
Yes, ignore the linter error for this. I will try to improve it. |
On SBSA platforms using standard UEFI firmware (such as EDK II), the watchdog timer is often enabled during early boot stages but explicitly disabled by the firmware before handing over control to the OS (e.g., during ExitBootServices). This is done to prevent unintended resets while the OS is loading, assuming the OS watchdog driver will take over. However, this leaves a protection gap. If the system hangs between the firmware handover and the userspace watchdog daemon startup, the hardware watchdog will not fire to recover the system. For safety-critical systems that require continuous hardware watchdog protection from the earliest possible moment, this gap is problematic. Add an 'early_enable' module parameter to allow the kernel driver to re-enable the watchdog immediately during probe if it was left disabled by the firmware. By setting the WDOG_HW_RUNNING status bit, the watchdog core is instructed that the hardware is active. As a result, the core's pre-userspace handler (controlled by 'handle_boot_enabled') will automatically issue periodic keepalives until userspace opens the device. This bridges the protection gap seamlessly without requiring firmware modifications and without risking unintended resets during kernel boot. The parameter defaults to false to preserve the traditional behavior. Signed-off-by: Zexin Wang <[email protected]> Link: https://patch.msgid.link/[email protected] Signed-off-by: Guenter Roeck <[email protected]> (backported from commit 11f93e639d51 groeck/linux-staging.git) Signed-off-by: Kaushal Rajeev Butala <[email protected]>
87b8b4e to
93bda09
Compare
kbutala-nv
changed the title
removed "NVIDIA: SAUCE:" from PR description and commit message. |
|
@kbutala-nv just one little thing:
|
@kbutala-nv Instead of appending "from groeck/linux-staging.git", just use "linux-next" since this patch is now in linux-next (same SHA). e.g. once picked it should look like: |
3 participants
This PR contains backport of change https://patch.msgid.link/[email protected]
We need this patch to support newer firmware revisions.
(backported from commit 11f93e639d51 groeck/linux-staging.git)