Skip to content

Disable Wuji SDK telemetry - #1439

Open
lotusl-code wants to merge 1 commit into
mainfrom
lotusl/disable-wuji-data-collection
Open

lotusl-code wants to merge 1 commit into
mainfrom
lotusl/disable-wuji-data-collection

Conversation

@lotusl-code

@lotusl-code lotusl-code commented Nov 5, 2026 •

Copy link
Copy Markdown
Contributor

Disable Wuji data collection:

Privacy Notice
Wuji SDK collects anonymous usage data to improve the product.
No personal or sensitive information is collected.
Privacy Policy: https://wuji.tech/terms

Summary by CodeRabbit

  • Updates
    • Wuji SDK telemetry is now disabled when the SDK is initialized through the glove plugin or Python package.
    • This setting overrides any existing value, providing consistent telemetry behavior across both entry points.

@coderabbitai

coderabbitai Bot commented Nov 5, 2026 •

Copy link
Copy Markdown
Contributor

Explain Change →

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review

No actionable comments were generated in the recent review.

Walkthrough

The Wuji glove plugin sets WUJI_TELEMETRY_DISABLE to "1" with overwrite enabled before calling wuji_init. The Python package sets the same environment variable before subsequent imports and plugin launches.

Estimated code review effort: 2 (Simple) | ~7 minutes

Merge Risk: Minimal · previous review 8e375

No actionable issue is established from the available evidence. The telemetry opt-out should still be confirmed against the SDK before relying on it.

Pre-merge checks: Passed 5

Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly describes the main change: disabling Wuji SDK telemetry.
Docstring Coverage Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 1 functions across 2 files.

Finishing Touches

Generate docstrings

  • Commit to this branch
  • Create a new PR
Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Tip

🎯 Customize your risk assessments

Guide how CodeRabbit assesses merge risk and security architecture risk. Highlight sensitive changes and explain your security boundaries using Merge Risk Instructions and Security Risk Instructions in your review settings. Security architecture risk assessments require the Advanced plan or above.

✅ Automatic approvals, with your rules

Let CodeRabbit approve pull requests once required threads are resolved, pre-merge checks pass, and your risk limits are met. Enable Automatic approvals in review settings, with overrides for teams or file paths.

Recent review info

Run configuration

Commits

Reviewing files that changed from the base of the PR and between eb359f4 and 8e37582.

Files selected for processing: 2

  • src/plugins/wuji_glove/wuji_glove_plugin.cpp
  • src/python/isaaccapture/__init__.py

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 11 remain after this review.

Comment thread src/python/isaaccapture/__init__.py Resolved
@lotusl-code
lotusl-code force-pushed the lotusl/disable-wuji-data-collection branch from 8e37582 to 5af9273 Compare November 6, 2026 22:41

This branch was successfully deployed

1 active deployment
dev — 5af9273b Deployed Nov 7, 2026 by lotusl-code via publish-wheel #6603
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants