Skip to content

🧹 [Refactor] Clean up lint suppressions and unused fields - #333

Draft
NITISH-R-G wants to merge 2 commits into
mainfrom
fix/code-quality-lint-suppressions-13960424110369546675
Draft

NITISH-R-G wants to merge 2 commits into
mainfrom
fix/code-quality-lint-suppressions-13960424110369546675

Conversation

@NITISH-R-G

@NITISH-R-G NITISH-R-G commented Aug 24, 2026 •

Copy link
Copy Markdown
Owner

🎯 What:

  • Added header: "" to l10n.yaml to prevent gen-l10n from generating inline ignore comments.
  • Moved experimental_member_use suppression to analysis_options.yaml globally.
  • Removed unused private _ref fields from WebRtcVoiceCallService and FamilyCircleService, but kept Ref ref in the constructors as per architectural comments.
  • Replaced // ignore: discarded_futures with unawaited(...) in FirstAidScreen.
  • Updated analysis_options.yaml to exclude lib/l10n/**.

💡 Why:
Enforce clean architecture and remove file-level lint suppression comments per production-grade standards. Keeping the codebase completely free of warnings while adhering to correct code semantics, avoiding "ignore" workarounds within source files.

✅ Verification:
Ran dart analyze (0 issues found) and flutter test (all tests passed).

✨ Result:
Improved code hygiene, consistent rules enforcement across the app, and removed 10+ unnecessary inline lint suppressions.


PR created automatically by Jules for task 13960424110369546675 started by @NITISH-R-G

Summary by Sourcery

Clean up lint configuration and unused service fields while making asynchronous intent explicit and preventing pull requests from using the deployment environment.

Enhancements:

  • Centralize analyzer exceptions and exclude generated localization files from analysis while eliminating unnecessary inline lint suppressions.
  • Remove unused service state while preserving constructor contracts and explicitly mark best-effort asynchronous work as unawaited.

CI:

  • Adjust the GitHub Pages workflow environment so pull requests do not target the deployment environment.

Chores:

  • Configure localization generation to omit generated file headers and inline ignore comments.

- Add header: "" to l10n.yaml to prevent gen-l10n from generating ignore comments.
- Move experimental_member_use suppression to analysis_options.yaml.
- Remove unused private fields _ref from WebRtcVoiceCallService and FamilyCircleService.
- Replace `// ignore: discarded_futures` with `unawaited()` in FirstAidScreen.
- Update analysis_options.yaml to exclude lib/l10n/**.

Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@greptile-apps greptile-apps Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your trial has ended. Reactivate Greptile to resume code reviews.

@coderabbitai

coderabbitai Bot commented Aug 24, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown
Contributor

Seems you are using me but didn't get OPENAI_API_KEY seted in Variables/Secrets for this repo. you could follow readme for more information

@sourcery-ai

sourcery-ai Bot commented Aug 24, 2026

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

The PR cleans up inline lint suppressions by moving applicable exceptions into analyzer configuration, preventing generated localization files from emitting suppression comments, removing unused Ref fields without changing constructor contracts, and explicitly marking a deliberately unawaited async call. Verification reports zero analyzer issues and passing tests.

Sequence diagram for explicitly unawaited first-aid advice refresh

sequenceDiagram
    participant Screen as FirstAidScreen
    participant Store as FirstAidStore

    Screen->>Store: getVerifiedAdvice(query)
    Note over Screen,Store: Future is intentionally not awaited
    Store-->>Screen: Future
Loading

File-Level Changes

Change Details Files
Centralize analyzer exceptions and exclude generated localization code from analysis.
  • Configured localization generation to omit inline headers and ignore comments.
  • Moved experimental API suppression to analyzer-level configuration.
  • Excluded generated localization files from analyzer diagnostics.
analysis_options.yaml
l10n.yaml
lib/services/emergency_beacon_service.dart
Remove unused dependency fields while preserving constructor compatibility.
  • Retained Ref constructor parameters for architectural and call-site compatibility.
  • Removed unused private Ref storage and its suppression comments.
lib/services/family_circle_service.dart
lib/services/webrtc_voice_call_service.dart
Replace an inline discarded-future suppression with explicit asynchronous intent.
  • Wrapped the best-effort side-effect call in unawaited(...).
lib/ui/first_aid_screen.dart

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

- Conditionally set github-pages environment in health_dashboard.yml to avoid PR environment protection rules failures.

Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>

@greptile-apps greptile-apps Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your trial has ended. Reactivate Greptile to resume code reviews.

@github-actions

Copy link
Copy Markdown
Contributor

Seems you are using me but didn't get OPENAI_API_KEY seted in Variables/Secrets for this repo. you could follow readme for more information

This branch had an error being deployed

1 failed (outdated) deployment
github-pages — 43275633 Deployed Aug 24, 2026 by NITISH-R-G via Generate & Deploy Dashboard #360
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant