Repository navigation
Access profiles: profile check, profile suggest and report-only profile findings in check - #54
Merged
Merged
Conversation
…ip or source grant
…sons incomplete; escape hidden characters in drafts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase 2 of the access-operations program: declare expected access and see what nobody explains.
What's new (experimental)
profiles/*.yamlandpeople/*.yamlnext topermesh.yaml, plus an optionalprofiles:section (enforce,directory_groups). Entries reference immutable provider IDs; includes are expanded with cycle detection; errors name the file.permesh profile check [--snapshot] [--policy]: per person, missing expected entries and unexplained access, with the group route (via) and certainty. Exits 0 / 6 findings / 4 incomplete / 3 all failed / 2 not configured.permesh profile suggest --group INSTANCE:GROUP_ID --name NAME [--min-percent N]: prints a reviewable YAML draft from what a group's members share.version: 2:unexplained_accessexceptions scoped to a membership (group) or one direct grant, with expiry. v1 files are unchanged.permesh check:unexplained_accessandmissing_accesscounts, report-only unlessprofiles.enforce: true(no effect on exit code, completeness or unfiltered notifications);profile_findingsin detail payloads; summary stays counts-only.profiles/andpeople/(not configured until YAML is added); ADR 0033,docs/profiles.md, schema/stability/check/notification docs.Safety properties
cannot_telland the comparison is incomplete.cannot_tell; expired exceptions don't apply.Verification
cargo fmt --check && cargo clippy --workspace --all-targets -- -D warnings && cargo test --workspace(610 passed) andscripts/check_docs.py. A whole-branch review found one critical (ambiguous accounts hid access while reporting complete) and two important issues; all fixed with failing-first tests in the last commit. Deferred minors: per-person path index rebuild (perf), report-only check failing on malformed profile files,.ymlignored silently, config error hint wording, empty-provider exit, report-only label in detail notifications.