Conversation
Updates the Build job's RunsOn in ScriptGenerationService.cs to BuildMachines.UbuntuLatest and regenerates .github/workflows/build.yml from the Infrastructure project. Also removes the now-unnecessary Windows-only "Enable long paths for Git" step. Test steps already declared Shell = "pwsh" explicitly, so they continue to run correctly on ubuntu-latest (pwsh is preinstalled there). Verified no database dependency (no UseSqlServer/UseNpgsql/DbContext/ dotnet ef/ConnectionStrings usage in project code), no .esproj projects, and no ProjectReference casing mismatches. Co-Authored-By: Claude Sonnet 5 <[email protected]> Claude-Session: https://claude.ai/code/session_013qa2PSvtyXPgZbxPyD8Uro
There was a problem hiding this comment.
🔵 Needs a closer look
A successful Ubuntu workflow run is required before merging.
Pull request overview
Migrates the generated CI build workflow from Windows to Ubuntu.
Changes:
- Switches the build runner to
ubuntu-latest. - Removes the Windows-only Git long-path step.
- Regenerates
.github/workflows/build.yml.
File summaries
| File | Summary |
|---|---|
NHSDigital.ApiPlatform.Infrastructure/Services/ScriptGenerationService.cs |
Updates the generated runner configuration and removes the Windows-only step. |
.github/workflows/build.yml |
Reflects the regenerated Ubuntu-based workflow. |
Review details
Suppressed comments (1)
NHSDigital.ApiPlatform.Infrastructure/Services/ScriptGenerationService.cs:44
- This runner switch changes the execution environment for all three
pwshtest loops, but the listed verification only builds locally and parses/lints YAML; it does not execute the generated workflow on Ubuntu. Please obtain a successful Ubuntu workflow run before merging so Linux-only path, shell, or test failures cannot reachmain.
RunsOn = BuildMachines.UbuntuLatest,
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #42
What changed
NHSDigital.ApiPlatform.Infrastructure/Services/ScriptGenerationService.cs: changed thebuildjob'sRunsOnfromBuildMachines.WindowsLatesttoBuildMachines.UbuntuLatest, and removed the now-unnecessary Windows-only "Enable long paths for Git" step..github/workflows/build.ymlregenerated from the Infrastructure project (never hand-edited).Verification performed
UseSqlServer,UseNpgsql,DbContext,dotnet ef,ConnectionStrings— no matches in actual project code (only unrelated skill/template examples under.agents/). This is a simple runner-only swap.Run Unit Tests,Run Acceptance Tests,Run Integration Tests) already declareShell = "pwsh"explicitly in the C# source, so they continue to run correctly onubuntu-latest(pwsh is preinstalled there) — no rewrite needed..esprojprojects in this repo.ProjectReferencepaths match actual directory names exactly (checked withls -d).EnvironmentVariablesdictionary present to clean up.build.ymldiffed against the committed version — only the intendedruns-onchange and step removal, all other logic (test scripts, tag/release/publish jobs) untouched.prLinter.ymlregenerated with the same tool but showed unrelated ADotNet package version drift (new prefix categories, try/catch wrapping) — reverted to keep this PR scoped to the runner migration only.python3 -c "import yaml; yaml.safe_load(...)"— YAML parses cleanly.actionlint— passes with no errors onbuild.ymlandprLinter.yml.dotnet build NHSDigital.ApiPlatform.slnx— full solution builds with 0 errors (34 pre-existing nullable-annotation warnings unrelated to this change).🤖 Generated with Claude Code
https://claude.ai/code/session_013qa2PSvtyXPgZbxPyD8Uro
Generated by Claude Code