Migrate CI build pipeline to Ubuntu (Linux) runner - #228
Merged
Merged
Conversation
Changes the build job's RunsOn from windows-latest to ubuntu-latest in ScriptGenerationService.cs (the ADotNet-based generator for .github/workflows/build.yml) and regenerates build.yml accordingly. This is CI-only: local development is unaffected. Verified no database dependency exists in the repo (no UseSqlServer/UseNpgsql/DbContext/ ConnectionStrings usage), no .esproj projects are present, and no ProjectReference casing mismatches exist between .csproj files and actual directory names. The full solution (including the net10.0-windows WinForms NEL.MESH.UI project, via EnableWindowsTargeting) restores and builds successfully on Linux with 0 errors. The regenerated workflow was validated with actionlint (exit 0) in addition to YAML syntax. Closes #227 Co-Authored-By: Claude Sonnet 5 <[email protected]> Claude-Session: https://claude.ai/code/session_013qa2PSvtyXPgZbxPyD8Uro
There was a problem hiding this comment.
🟢 Approval recommended
No unresolved review issues remain, and all reviewers assessed it as ready.
Pull request overview
Migrates the CI build job from Windows to Ubuntu while keeping the generated source and workflow consistent.
Changes:
- Updates the source generator to use
BuildMachines.UbuntuLatest. - Regenerates the workflow with
ubuntu-latest.
File summaries
| File | Description |
|---|---|
NEL.MESH.Infrastructure/Services/ScriptGenerationService.cs |
Updates the generated runner configuration. |
.github/workflows/build.yml |
Applies the Ubuntu runner to the build workflow. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
The
buildjob in.github/workflows/build.ymlnow runs onubuntu-latestinstead ofwindows-latest. This file is generated byNEL.MESH.Infrastructure(an ADotNet-based script generator), so the change was made inScriptGenerationService.cs'sRunsOnproperty and the workflow was regenerated from source, not hand-edited.This is CI-only — local development is completely unaffected.
Why
Standardizing CI runners for repos tagged
Team=Digital Development Teamfrom Windows to Linux, for cost and consistency with other repos in the org.Verification performed
UseSqlServer,UseNpgsql,DbContext,dotnet ef,ConnectionStrings— none found (only unrelated matches in.agents/skillstemplate/example files, not actual project code). No Docker/SQL Server CI steps were needed or added..esprojprojects: none present in the solution, so no Linuxdotnet restoreblocker from the JavaScript SDK's Windows-only TargetFrameworkVersion issue.ProjectReferencepath in every.csprojagainst actual on-disk directory names — all match exactly, no case-sensitivity issues that would break on Linux.dotnet restoreanddotnet buildagainstNEL.Mesh.slnxboth succeed with 0 errors, including thenet10.0-windowsWinFormsNEL.MESH.UIproject — it builds fine viaEnableWindowsTargeting, so no.slnffilter was needed.actionlint(a GitHub Actions schema linter, not just YAML syntax) with exit code 0.build.ymlagainst the previously committed version to confirm no unrelated regression — the only diff is theruns-online.Closes #227
🤖 Generated with Claude Code
https://claude.ai/code/session_013qa2PSvtyXPgZbxPyD8Uro
Generated by Claude Code