Skip to content

PWN layer model v3.0.0: follow up on remaining PR 77 review comments #78

Open

Description

@bdestombe

Context

Follow-up to #77. This issue tracks remaining review questions separately so the layer-model addition can be merged without losing them.

Open work

  • Verify that the shipped v3 botm.geojson and botm_incl_source.geojson use the v3 layer names and translation table consistently; regenerate if necessary. The original comment reported the old koppeltabel scheme: Request to add layer model version 3.0.0 #77 (comment). The PR now includes a v3 bodemlagenvertaaltabel.csv and documents W21A/S21A/W21B, but the exported point data still need an explicit consistency check.
  • Resolve the geological resistance-allocation question for S21A versus S13/S21 using the Stuyfzand source material. Establish whether any resistance must be reassigned rather than added, and document the conclusion. The conductance addition itself is implemented: S21A now uses Bergen C1D/CL4, while S13/S21 inputs are not reduced. Do not treat the original missing-conductance comment as wholly unaddressed. Discussion: Request to add layer model version 3.0.0 #77 (comment) and Request to add layer model version 3.0.0 #77 (comment); current behavior is documented in the PR README.
  • Coordinate with NHFLO/tools to evaluate interpolating bottoms from all original data points before applying masks on the MODFLOW grid, avoiding artificial relocation of points at mask boundaries. Compare the interpolated surfaces and boundary behavior before adopting this change. Proposal: Request to add layer model version 3.0.0 #77 (comment).
  • Audit the new generation scripts for repository-relative sys.path manipulation. Where still present, use an editable installation (pip install -e .), normal imports, and get_abs_data_path() instead; document how to run the scripts. botm.py already uses a normal nhflodata import and get_abs_data_path(), so this is a remaining-script audit, not a request to redo that fix. Review comment: Request to add layer model version 3.0.0 #77 (comment).

Process note

Keep future dataset-copy commits separate from substantive model/code changes and use smaller commits, as requested in #77 (comment).

Related existing tracking: #76 (version/translation-table clarity), #59 (interpolation boundaries), and #66 (aquitard transmissivity double counting). These are not automatically resolved by merging #77.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions