Skip to content

Add configurable web transport paths#223

Draft
durck wants to merge 1 commit into
NHAS:mainfrom
durck:fix/custom-web-transport-paths
Draft

Add configurable web transport paths#223
durck wants to merge 1 commit into
NHAS:mainfrom
durck:fix/custom-web-transport-paths

Conversation

@durck

@durck durck commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Summary

Adds configurable web transport paths for WebSocket and HTTP(S) polling transports. Defaults remain /ws and /push.

Details

  • Adds server --ws-path and --push-path options.
  • Adds client --ws-path and --push-path options.
  • Lets link --ws-path and link --push-path bake paths into generated clients.
  • Lets the Docker entrypoint pass RSSH_WS_PATH and RSSH_PUSH_PATH into server startup.
  • Normalizes configured paths with a leading slash and no trailing slash.
  • Updates mux HTTP classification and WebSocket unwrap to use configured paths.

Validation

  • go test ./pkg/transport ./internal/client ./pkg/mux
  • go test -vet=off ./cmd/client ./cmd/server ./internal/server ./internal/server/commands ./internal/server/webserver
  • bash -n docker-entrypoint.sh via Git Bash
  • git diff --check

Server package validation uses -vet=off because upstream currently has unrelated non-constant format string vet findings; this PR intentionally does not include formatting-only cleanup.

return err
}

buildConfig.WSPath, err = line.GetArgString("ws-path")

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With both of these as you've got a buffer length of 1024 we need to limit the user here to that length

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants