fix(packaging): canonical SPDX license expression (0.3.4) - #25
Conversation
- license = "GPL-3.0-only" instead of the deprecated "GPL-3.0" SPDX identifier. Same license, canonical machine-readable spelling; setuptools warns on deprecated identifiers and PyPI validates them. Version bumped to 0.3.4 with the matching CHANGELOG section and comparison links. Verified: 777 tests pass, ruff clean.
|
Warning Review limit reached
Next review available in: 29 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
Comment |
Greptile SummaryThe PR updates the package to version 0.3.4 and replaces the deprecated license identifier with the canonical
Confidence Score: 4/5The PR appears safe to merge, with a non-blocking release-note completeness issue in the changelog. The package metadata and version sources remain consistent, but the new 0.3.4 section would omit dependency-floor changes shipped from the same revision. Files Needing Attention: CHANGELOG.md
|
| Filename | Overview |
|---|---|
| pyproject.toml | Correctly bumps the package version and uses a canonical SPDX expression consistent with the repository license. |
| mailvalidator/init.py | Keeps the source-tree fallback version synchronized with project metadata. |
| CHANGELOG.md | Adds correct 0.3.4 release links but does not move the existing Unreleased changes into the versioned section. |
Reviews (1): Last reviewed commit: "fix(packaging): canonical SPDX license e..." | Re-trigger Greptile
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
The version bump left already-shipped changes under [Unreleased], so the versioned section and its GitHub release notes would have omitted work shipped from the same revision. CHANGELOG rule: never leave content under [Unreleased] after bumping the version. Caught by Greptile on the mailvalidator PR; the same defect was present in this module.
There was a problem hiding this comment.
t0kubetsu has reached the 50-credit limit for trial accounts. To continue receiving code reviews, upgrade your plan.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
1 participant
Problem
pyproject.tomldeclaredlicense = "GPL-3.0". That is a deprecated SPDXidentifier: setuptools warns on it and PyPI validates license expressions, so the
correct spelling is
GPL-3.0-only(orGPL-3.0-or-later). The license itself isnot changing — only its machine-readable form.
Change
license = "GPL-3.0-only"pyproject.tomland the__init__.pyfallbackliteral, with the matching
CHANGELOG.mdsection and comparison links.No source code, API or behaviour changed.
Verification
The equivalent change was verified end-to-end on a built wheel
(
License-Expression: GPL-3.0-only,dist-info/licenses/LICENSEpresent).Part of an org-wide sweep: every module carried the same deprecated identifier.
Follows quantumvalidator, which shipped this in v0.6.4.