Skip to content

Show live plan revision in the metadata panel - #1942

Open
AaronPlave wants to merge 1 commit into
developfrom
fix/18/plan-metadata-revision-fix
Open

Show live plan revision in the metadata panel#1942
AaronPlave wants to merge 1 commit into
developfrom
fix/18/plan-metadata-revision-fix

Conversation

@AaronPlave

Copy link
Copy Markdown
Contributor

Summary

Include plan revision in plan metadata subscription so that plan revision updates in plan metadata panel. Additionally refactors planRevision store to use the new live revision value instead of an independent subscription. Closes #1938.

Visible UX Changes

  • plan revision should increase in the plan metadata panel input when the plan is changed

Verification

  • New plan-metadata.test.ts test added to ensure plan revision increases after plan name change

@AaronPlave
AaronPlave requested a review from a team as a code owner June 8, 2026 23:44
@AaronPlave AaronPlave self-assigned this Jun 8, 2026
@AaronPlave AaronPlave added the fix A bug fix label Jun 8, 2026
Comment thread src/utilities/gql.ts
}
`,

GET_PLAN_REVISION: `#graphql

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there still a need for explicitly querying for the plan's revision? It looks like this is used by schedule(), which already takes the plan object as a parameter. Can we just use the revision on that?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we do run a getPlanRevision in plan-metadata.test.ts too - guess we could get the whole plan instead there? fine by me either way if you have a preference.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the test, can we capture the version prior to plan update via the revision input field value and use that to compare after updating?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Issue was that it was sometimes lagging behind due to web socket lag so we'd have to wait for it to actually change or fetch the plan object again which might be simpler?

@AaronPlave
AaronPlave force-pushed the fix/18/plan-metadata-revision-fix branch from 51582e8 to dcc6f8b Compare June 16, 2026 00:07
@AaronPlave
AaronPlave force-pushed the fix/18/plan-metadata-revision-fix branch from dcc6f8b to 9cf11dd Compare June 16, 2026 15:36
@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix A bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Revision Column in Plan Metadata Tab does not automatically update

2 participants