Show live plan revision in the metadata panel - #1942
Conversation
| } | ||
| `, | ||
|
|
||
| GET_PLAN_REVISION: `#graphql |
There was a problem hiding this comment.
Is there still a need for explicitly querying for the plan's revision? It looks like this is used by schedule(), which already takes the plan object as a parameter. Can we just use the revision on that?
There was a problem hiding this comment.
we do run a getPlanRevision in plan-metadata.test.ts too - guess we could get the whole plan instead there? fine by me either way if you have a preference.
There was a problem hiding this comment.
For the test, can we capture the version prior to plan update via the revision input field value and use that to compare after updating?
There was a problem hiding this comment.
Issue was that it was sometimes lagging behind due to web socket lag so we'd have to wait for it to actually change or fetch the plan object again which might be simpler?
51582e8 to
dcc6f8b
Compare
dcc6f8b to
9cf11dd
Compare
|



Summary
Include plan revision in plan metadata subscription so that plan revision updates in plan metadata panel. Additionally refactors planRevision store to use the new live revision value instead of an independent subscription. Closes #1938.
Visible UX Changes
Verification