Repository navigation
Publish the container image on Docker Hub as alignair/alignair - #14
Merged
Merged
Conversation
…r) and GHCR Build the image once, smoke it, then push :<version> and :latest to Docker Hub as the primary name and to ghcr.io/mutejester/alignair as a mirror. Docker Hub login uses the DOCKERHUB_TOKEN repository secret. The job runs before the immutable PyPI step, as before.
README, examples and docs site now pull alignair/alignair, with ghcr.io/mutejester/alignair noted as an identical mirror for clusters that hit Docker Hub's anonymous pull limit. The Galaxy, Nextflow and Snakemake wrappers pointed at thomask90/alignair:latest, the legacy TensorFlow image, which has no `alignair predict` command; pin them to alignair/alignair:3.0.0. Drop the stale 'no published model/container' prerequisites from workflows/README.md.
…ge push Release workflow: - log in to Docker Hub before the build so base-image pulls are authenticated - push :<version> to both registries before moving :latest, so a failed push never leaves :latest ahead of PyPI; pre-release versions never move :latest - take the Docker Hub username from vars.DOCKERHUB_USERNAME (default: alignair) Wrappers: - the image's ENTRYPOINT is `alignair` and Nextflow does not override entrypoints by default, so every task ran `alignair /bin/bash ...` and failed; the docker profile now clears the entrypoint and runs as the host user - document the Galaxy job-config override and its disabled networking - remove the remaining 'unpublished image/model' text; recommend a local model for containers Add a test that every pinned alignair/alignair and GHCR tag matches pyproject's version.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
alignair/alignair, primary) and GHCR (ghcr.io/mutejester/alignair, mirror).:<version>goes to both registries first.:latestmoves only after that, and never for pre-release versions.DOCKERHUB_TOKENsecret, which is set, andvars.DOCKERHUB_USERNAME, which defaults toalignair.examples/README.mdand the docs site now showdocker pull alignair/alignair. GHCR is noted as a mirror for clusters that hit Docker Hub's anonymous pull limit.thomask90/alignair:latest, the legacy TensorFlow image, which has noalignair predictcommand. They are now pinned toalignair/alignair:3.0.0.ENTRYPOINTisalignair, and Nextflow doesn't override entrypoints by default, so every task ranalignair /bin/bash …and failed. The Nextflowdockerprofile now sets--entrypoint "" -u $(id -u):$(id -g).workflows/README.md.tests/alignair/test_container_pins.pychecks that every pinnedalignair/alignair/ GHCR tag in the docs and wrappers matches pyproject's version.alignair/alignair:3.0.0and:latestare already on Docker Hub, pushed from the GHCR3.0.0image. They are a plain linux/amd64 manifest, like GHCR, so Apple Silicon machines pull and emulate them rather than failing on a manifest list. The image ID (configsha256:ff7aa97f…) is the same on both registries. The compressed-layer digests differ because Docker re-compresses layers on push.Verification
alignair/alignair:3.0.0.alignair: error: argument command: invalid choice: '/bin/bash'.runOptions: the task runs, and its output is owned by the host user.npm ci && npm run buildinwebsite/passes.pytest tests/alignair/test_container_pins.py tests/alignair/test_conda_recipe.py tests/alignair/cli/test_docs_cli_sync.py: 33 passed.actionlintonrelease.ymlfinds nothing new. Its existing findings (themacos-15-intellabel, info-level shellcheck notes) are on lines this PR doesn't touch.Not in this PR
containersjob: this rebuilds the image and can overwrite an already-pushed:<version>with a different digest.The PyPI README updates at the next release. The GitHub README and the docs site update on merge.