Repository navigation
Conversation
…start CommonClient.py: the takeover hands the manager a world's own run_gui made to GameClient before ctx.ui becomes the live app. ClientBuilder.py: LegacyKvuiClientBuilder builds that instance in place of the make_gui() class. kvui.py: GameManager.build_for_live_app takes an existing manager and runs its on_start after the build; GameManager.on_start is the no-op target for super().on_start(). test/general/test_client_compat.py: world-made manager resolution, the takeover hand-off, and build_for_live_app's on_start.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
The post-takeover build of a world client's own GUI manager, and its Kivy
on_startoverride.Description
GameManagerin their ownrun_gui. Itsasync_runtook over the live app without ever calling itsbuild(), so their custom tabs never appeared. The takeover now hands that manager toLegacyKvuiClientBuilder, which builds it in place of themake_gui()class.GameManager.build_for_live_appaccepts that existing manager and runs itson_startafter the build, as Kivy'sApp.rundoes. Failures are logged and the build is kept. The new no-opGameManager.on_startkeepssuper().on_start()working, and stops a manager without an override from forwarding to the live app'son_start.MultiMDAppsubclass (tboir) and runs itson_start.Not covered by unit tests: a headless probe of the real frontend on both branches ran a run_gui
GameManagerthrough the real takeover. Its custom tab was added, and itson_startran once. Onmain, it was never built.