Skip to content

Mm rework - #12

Closed
hustonm wants to merge 153 commits into
devfrom
mm_rework
Closed

hustonm wants to merge 153 commits into
devfrom
mm_rework

Conversation

@hustonm

@hustonm hustonm commented Aug 28, 2025

Copy link
Copy Markdown
Contributor

Motion models operational, with Acceleration and Parallax available now.

Macy Huston and others added 30 commits January 4, 2024 16:12
pull in changes made to main

@jluastro jluastro left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More inline comments overall would be useful. And some of the method comments aren't formatted correctly, I think. Otherwise, looks good.

Comment thread flystar/fit_velocity.py Resolved
Comment thread flystar/fit_velocity.py Resolved
Comment thread flystar/motion_model.py Resolved
Comment thread flystar/motion_model.py Resolved
Comment thread flystar/motion_model.py Resolved
Comment thread flystar/motion_model.py Resolved
Comment thread flystar/parallax.py Resolved

@jluastro jluastro left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor change with leftover pdb.set_trace().

Comment thread flystar/align.py Resolved
Removed debugging code for initial transformation match.
@jluastro

Copy link
Copy Markdown
Collaborator

Closing in favor of #26, which has now been merged into dev. mm_rework_lingfeng was branched from mm_rework and contains all of its work; the one later mm_rework commit (d643f67, removing the pdb breakpoint in MosaicSelfRef) was already applied on mm_rework_lingfeng independently. The mm_rework branch itself is left in place.

@jluastro jluastro closed this Oct 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants