Skip to content

chore: lower Java requirement from 25 to 17 - #24

Merged
MoshPe merged 3 commits into
mainfrom
chore/java17-compat
Apr 18, 2026
Merged

MoshPe merged 3 commits into
mainfrom
chore/java17-compat

Conversation

@MoshPe

@MoshPe MoshPe commented Apr 18, 2026 •

Copy link
Copy Markdown
Owner

Summary

  • pom.xml: maven.compiler.release 25 → 17
  • All 5 workflows (ci, release, snapshot, codeql, dependency-check): java-version: '25' → '17'
  • List.getFirst() → List.get(0) in 6 files (DemoClientMain, AckTrackerTest, ServerConfigLoaderTest, DemoClientSwarmTest, PrometheusMetricsParserTest, DemoLauncherActionDelegateTest) — getFirst() is Java 21 SequencedCollection API, not available in Java 17
  • Child POM versions synced (1.0.1 → 1.0.8-SNAPSHOT) so the multi-module build resolves correctly
  • Release workflow fixed: removed -N from versions:set so all three pom.xml files are updated on version bumps; removed missing --label "dependencies" that was causing the workflow to fail
  • README: Java badge updated to Java 17

Test plan

  • CI passes on this PR (builds and tests under Java 17)
  • All 114 tests pass locally ✅

- pom.xml: maven.compiler.release 25 → 17
- All 5 CI workflows: java-version '25' → '17', step names updated
- Replace List.getFirst() (Java 21 SequencedCollection API) with
  List.get(0) in DemoClientMain, AckTrackerTest, ServerConfigLoaderTest,
  DemoClientSwarmTest, PrometheusMetricsParserTest,
  DemoLauncherActionDelegateTest
- Sync child module parent versions (1.0.1 → 1.0.8-SNAPSHOT)
- Fix release workflow: remove -N from versions:set so child POMs are
  updated too; stage all three pom.xml files; drop missing 'dependencies'
  label from gh pr create
- README: update Java badge to Java 17

All 114 tests pass under Java 17.
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@MoshPe
MoshPe merged commit 70e2860 into main Apr 18, 2026
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants