Comments branch Review - #23
Open
MosDevx wants to merge 21 commits into
Open
Conversation
aster-alemu
reviewed
Dec 2, 2022
|
|
||
| **[Movie Api]** is a javascript project | ||
| **[Movie Api]** is a javascript project that fetches TV Show Data from an API | ||
|
|
Collaborator
There was a problem hiding this comment.
Hi @MosDevx
Good job so far!
To Highlight! 👏 🟢
- Good commit messages,
- Great folder structure
- Clean code
- Good PR description
- Your project is running free of Linter errors
There is some issue that you still need to work on but you are almost there!
Required Changes ♻️
Kindly add the link of live demo on your READEME file
aster-alemu
requested changes
Dec 2, 2022
|
|
||
| We would like to thank Microverse | ||
|
|
||
| <p align="right">(<a href="#readme-top">back to top</a>)</p> |
Collaborator
There was a problem hiding this comment.
Hi @MosDevx
Good job so far!
To Highlight! 👏 🟢
Good commit messages,
Great folder structure
Clean code
Good PR description
Your project is running free of Linter errors
There is some issue that you still need to work on but you are almost there!
Required Changes ♻️
- Kindly remove the same element descriptions on your README file
- Kindly add the link of your project live demo
aster-alemu
approved these changes
Dec 2, 2022
aster-alemu
left a comment
aster-alemu
left a comment
Collaborator
There was a problem hiding this comment.
Status: APPROVED 🏆 🎉 🎊
- Your project is complete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Create a module to Display user comments from Invlovement API
Create amodule to display a shows detail in full from the TvMaze API
Create a function to display number of comments visible on the screen