Repository navigation
Fix ENA cart addition when sample metadata is missing - #299
pansapiens merged 1 commit into
Conversation
edac88e
into
MonashBioinformaticsPlatform:master
|
Thanks - it would be useful to know which ENA or SRA accession can reproduce the original issue - it would be worth inspecting in case it can be mocked as a unit test. |
|
Thank you for merging my request and for the suggestion. I checked the ENA API and found a potential reproducer:
I also performed a check on the frontend set-up. It is running Vue 2.7.16 but the |
This PR fixes an issue where ENA FASTQ files could not be added to the cart when the associated sample metadata was unavailable on ENA.
What changed?
The ENA species lookup is now handled separately from adding samples to the cart. If the sample metadata lookup fails, the error is caught and the FASTQ samples can still be added to the cart. The species lookup is still used when the sample metadata is available, so automatic reference genome selection continues to work normally.
To test
I ran
npm run build:devsuccessfully.I verified the working tree and diff before committing.