Repository navigation
fix(serve): wait to resume a transcript an in-flight submit is writing - #186
Draft
cursor[bot] wants to merge 1 commit into
Draft
cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
session.resume was queued with frames that name no session, so it could read a transcript while prompt.submit was still appending. The fork then dropped that trailing user turn and the client left the run that held the reply. Co-authored-by: moikapy <[email protected]>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A
session.resumeon a connection that is already runningprompt.submitfor that same transcript used the session-less frame lane, so it read the file mid-run.read_session_messagesthen dropped the trailing user line, and the client switched to a fork that did not contain the in-flight turn (the reply stayed on the old bag).session.resumeis now queued byparams.id, so resuming the transcript a submit is still writing waits until that run finishes. A resume of a different id still does not wait.Validated with
node node_modules/vitest/vitest.mjs run test/serve_prompts.test.tsandtsc --noEmit.