Repository navigation
test: cover profile edges and telegram /start boundaries - #175
Draft
cursor[bot] wants to merge 1 commit into
Draft
cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
Lock soul-only profiles, ignored project keys, bad selectors, and profile CLI failures, plus the /start cases that must stay literal. Co-authored-by: moikapy <[email protected]>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Risky behavior now covered:
~/.lich/profiles) can be soul-only, must ignorework_dir/session_dir, and must not treat a JSON array as a usable layer or fall through to the soul file.LICH_PROFILEis rejected as an invalid name.lich profilerejects extra arguments, missing names, path-like names, a non-TTY create, and a cancelled wizard without writing a file.listignores non-slug filenames.useaccepts a soul-only profile./start@botwith no payload is still rewritten tohello./start/foo,/start@, and Discord/startstay literal. A failed gatewayreply()carries no usage, andhandle()drops an empty final reply whilereply()returns the empty text.Test files updated:
test/cli_config.test.tstest/first_run.test.tstest/gateway.test.tsWhy this reduces regression risk:
These paths landed in #170–#172 and #174. The existing tests cover the happy merge and the reported
/startedcase. A loosened profile slug, a profile that redirectswork_dir, a corrupt profile JSON that silently becomes a soul, or a/startprefix match would change which config and which prompt the agent runs. The new cases fail if those boundaries move.Validation:
node node_modules/vitest/vitest.mjs run test/cli_config.test.ts test/first_run.test.ts test/gateway.test.ts(104 passed) andbun x tsc --noEmit.