[Modsofthenation]

Summary

pnpm -r typecheck was still failing on @prm/api (called out in AGENTS). For a public merge bar that is unacceptable.

Changes

• Fix ReviewDTO mapping, logActivity null entity ids, director briefing narrowing, and P1 assignmentFor typing
• Add pnpm -r typecheck to CI before pnpm test
• Update AGENTS.md (typecheck is now expected green)

Test plan

• pnpm -r typecheck passes
• pnpm test (73 pass)

  

Summary by CodeRabbit

• Quality Improvements

  • Automated checks now include recursive type validation alongside the test suite.
  • Review and contribution guidance now clearly identifies typechecking and tests as required merge criteria.

• Reliability

  • Improved handling of optional activity metadata and review data during API processing.
  • Clarified assignment and briefing data handling to support more consistent API behavior.

[coderabbitai]

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 0b3ac812-9646-4aeb-8487-f399863e8a5d

📥 Commits

Reviewing files that changed from the base of the PR and between 086455f and 58a28be.

📒 Files selected for processing (5)

• .github/workflows/ci.yml
• AGENTS.md
• CONTRIBUTING.md
• apps/api/src/index.ts
• apps/api/src/store.ts

---

📝 Walkthrough

Walkthrough

The change adds recursive workspace typechecking to CI and contributor guidance. It also tightens API typing for review mapping, bundle generation, route assignment, and nullable activity logging.

Changes

Typecheck and API contracts

Layer / File(s)	Summary
API type contracts and adapters apps/api/src/index.ts, apps/api/src/store.ts	Review mapping now returns ReviewDTO. Readonly bundle generation reuses a typed briefing value. P1 route assignment mapping returns selected identifiers or null. logActivity accepts explicit null identifiers.
Workspace typecheck validation .github/workflows/ci.yml, AGENTS.md, CONTRIBUTING.md	CI runs pnpm -r typecheck before tests. Contributor guidance requires typechecking and tests as the merge gate.

Estimated code review effort: 2 (Simple) | ~10 minutes

Suggested reviewers: cursoragent

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch cursor/api-typecheck-ci-9b7f

---

_{Comment @coderabbitai help to get the list of available commands.}