fix: group account notifications by feed by Alessandro100 · Pull Request #254 · MobilityData/mobilitydatabase-web

Alessandro100 · 2026-10-19T13:08:48Z

Closes #252

Problem

The Account > Notifications table showed one row per subscription. The backend keeps a single subscription per (user, notification type) and merges every subscribed feed into it, so the page listed one row per type with all of its feeds joined into the title.

Testing on the preview also showed a related bug: deleting a subscription to unsubscribe from one feed unsubscribed the user from every feed of that type. This affected the feed page's Unsubscribe button and the notification settings dialog.

Changes

One row per feed. Subscriptions are grouped by feed, and the Type column lists that feed's notification types. Global subscriptions (e.g. announcements) keep their own row. The grouping is a pure helper, account/notifications/lib/groupSubscriptions.ts, with unit tests.
Per-feed unsubscribe. Unsubscribe on a feed row, the feed page's Unsubscribe button and unticking a type in the settings dialog now remove only that feed, via PATCH /v1/user/subscriptions/{id} with remove_feed_ids (new removeFeedsFromUserSubscription). The backend deletes the subscription when its last feed is removed.
No per-feed pause. active is per notification type, so a single feed can't be paused. Feed rows show Notification Settings and Unsubscribe; Pause/Resume stays on global rows such as Announcements.
Notification Settings per feed. Feed rows open the existing NotificationSettingsDialog, which was rendered on this page but couldn't be opened.
API types synced. external_types/UserServiceAPI.yaml and DatabaseCatalogAPI.yaml are copied from mobility-feed-api main, and the user service types are regenerated with yarn generate:user-api-types. The catalog types (feeds/types.ts) regenerate identically, so only the YAML copy changed there.
Cache fix on subscribe. Subscribing can return an existing subscription that the feed was merged into, so cached entries are now replaced by ID rather than appended a second time. Helpers in utils/subscriptionCache.ts, with unit tests.

Row status is Active if any of the feed's subscriptions is active.

Testing

yarn lint: 0 errors
yarn test:ci: 541/541 pass
npx tsc --noEmit: clean
Checked on the Vercel preview with a signed-in account. Screenshots are in the comments.

🤖 Generated with Claude Code

The Account > Notifications table showed one row per subscription, and subscribing to a feed creates one subscription per notification type, so a single feed was split across several rows. Rows are now grouped by feed, each listing all of that feed's notification types. Global subscriptions (announcements) keep their own row. Row actions apply to every subscription in the row, and feed rows gain a "Notification Settings" entry that opens the existing settings dialog, which was rendered on this page but never reachable. Closes #252 Co-Authored-By: Claude Opus 5.5 <[email protected]>

vercel · 2026-10-19T13:08:55Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated
mobilitydatabase-web	Ready	Preview	Oct 20, 2026 2:46pm UTC

github-actions · 2026-10-19T13:19:42Z

*Lighthouse ran on https://mobilitydatabase-dlnftyg73-mobility-data.vercel.app/ * (Desktop)
⚡️ HTML Report Lighthouse report for the changes in this PR:

Performance	Accessibility	Best Practices	SEO
🟠 62	🟢 94	🟢 96	🟢 100

*Lighthouse ran on https://mobilitydatabase-dlnftyg73-mobility-data.vercel.app/feeds * (Desktop)
⚡️ HTML Report Lighthouse report for the changes in this PR:

Performance	Accessibility	Best Practices	SEO
🟠 76	🟠 87	🟢 96	🟢 100

*Lighthouse ran on https://mobilitydatabase-dlnftyg73-mobility-data.vercel.app/feeds/gtfs/mdb-2126 * (Desktop)
⚡️ HTML Report Lighthouse report for the changes in this PR:

Performance	Accessibility	Best Practices	SEO
🔴 33	🟢 94	🟢 96	🟢 100

*Lighthouse ran on https://mobilitydatabase-dlnftyg73-mobility-data.vercel.app/feeds/gtfs_rt/mdb-2585 * (Desktop)
⚡️ HTML Report Lighthouse report for the changes in this PR:

Performance	Accessibility	Best Practices	SEO
🟠 83	🟠 84	🟢 96	🟢 100

*Lighthouse ran on https://mobilitydatabase-dlnftyg73-mobility-data.vercel.app/feeds/gbfs/gbfs-flamingo_porirua * (Desktop)
⚡️ HTML Report Lighthouse report for the changes in this PR:

Performance	Accessibility	Best Practices	SEO
🟢 93	🟢 94	🟢 96	🟢 100

…iptions The backend keeps one subscription per (user, notification type) and merges new feeds into it, so deleting a subscription to unsubscribe from one feed also unsubscribed the user from every other feed of that type. This affected the account page row actions, the feed page Unsubscribe button and the notification settings dialog. - Sync UserServiceAPI.yaml and DatabaseCatalogAPI.yaml from mobility-feed-api main and regenerate the user service types, which adds remove_feed_ids to the subscription update request. - Add removeFeedsFromUserSubscription and use it wherever a single feed is unsubscribed. - Drop Pause/Resume from feed rows on the account page: active is per notification type, so one feed cannot be paused on its own. Global rows (announcements) keep it. - Replace rather than append cached subscriptions on subscribe, since the API can return an existing subscription the feed was merged into. Co-Authored-By: Claude Opus 5.5 <[email protected]>

Copilot

🟡 Changes recommended

Paused-subscription settings and concurrent unsubscribe handling can leave notification state inconsistent.

3 open issues

What changed in this PR

Addresses #252 by grouping account notifications by feed and limiting unsubscribe actions to the selected feed.

Changes:

Adds feed-grouped rows and per-feed notification settings.
Uses targeted feed removal and updates subscription caching.
Syncs API definitions and adds helper tests.

Applied vercel-react-best-practices (custom).

File	Description
src/app/utils/subscriptionCache.ts	Adds cache update helpers.
src/app/utils/subscriptionCache.spec.ts	Tests cache helpers.
src/app/services/user-service-api-types.ts	Updates generated subscription types.
src/app/services/notification-service.ts	Adds targeted feed removal.
src/app/screens/Feed/components/NotificationSettingsDialog.tsx	Removes only the selected feed.
src/app/screens/Feed/components/ClientSubscribeControls.tsx	Updates unsubscribe and cache handling.
src/app/[locale]/account/notifications/lib/groupSubscriptions.ts	Groups subscriptions by feed.
src/app/[locale]/account/notifications/lib/groupSubscriptions.spec.ts	Tests grouping and titles.
src/app/[locale]/account/notifications/AccountNotifications.tsx	Renders feed rows and settings actions.
external_types/UserServiceAPI.yaml	Syncs subscription API contracts.
external_types/DatabaseCatalogAPI.yaml	Syncs validation-history definitions.

_{Review effort: Balanced}

Address review feedback on the per-feed subscription actions: - Initialize the notification settings checkboxes from feed membership rather than `active`, so a paused type can still be unchecked and the feed removed from it (account page and feed page). - Add settleAll, which waits for every request before rejecting, and use it for multi-request updates so the resync after a partial failure sees every completed request. The settings dialog now resyncs after a partial failure too. - Disable account page row actions while an update is in flight: feeds share subscriptions, and overlapping mutations on the same SWR key could restore a row that was already removed. Co-Authored-By: Claude Opus 5.5 <[email protected]>

Alessandro100 · 2026-10-20T11:30:37Z

Important to highlight: The way the backend is setup, we cannot offer the 'pause' action on a per feed basis, only on the notification type as a whole

Alessandro100 · 2026-10-20T11:40:44Z

Important to highlight: The date we display on the table is for the subscription as a whole, but we display the notifications grouped by feed. Would it be possible to get a created_at field per feed element? Otherwise the dates of the subscription will always be the date when the original subscription was created cc @davidgamez

Another alternative is to just remove the dates all together

Drop the Subscribed column and its sort option from the account notifications table, along with the now-unused createdAt field on grouped rows and its unit test. Co-Authored-By: Claude Opus 5.5 <[email protected]>

emmambd · 2026-10-20T15:57:44Z

LGTM! Thanks for making this improvement

abigailmbd

LGTM

davidgamez

LGTM

vercel Bot deployed to Preview October 19, 2026 13:09

View deployment

vercel Bot deployed to Preview October 19, 2026 14:07

View deployment

Alessandro100 requested a balanced review from Copilot October 20, 2026 11:08

Copilot started reviewing on behalf of Alessandro100 October 20, 2026 11:09

View session

Copilot AI reviewed Oct 20, 2026

View reviewed changes

Comment thread src/app/[locale]/account/notifications/AccountNotifications.tsx Outdated

Comment thread src/app/[locale]/account/notifications/AccountNotifications.tsx Outdated

Comment thread src/app/[locale]/account/notifications/AccountNotifications.tsx Outdated

vercel Bot deployed to Preview October 20, 2026 11:19

View deployment

Alessandro100 self-assigned this Oct 20, 2026

refactor: remove the subscribed date column from account notifications

6497b42

Drop the Subscribed column and its sort option from the account notifications table, along with the now-unused createdAt field on grouped rows and its unit test. Co-Authored-By: Claude Opus 5.5 <[email protected]>

vercel Bot deployed to Preview October 20, 2026 14:46

View deployment

emmambd requested a review from abigailmbd October 20, 2026 15:53

abigailmbd approved these changes Oct 22, 2026

View reviewed changes

davidgamez approved these changes Oct 27, 2026

View reviewed changes

Alessandro100 merged commit 177f733 into main Oct 27, 2026
4 checks passed

Navigation Menu

Repository navigation

fix: group account notifications by feed - #254

fix: group account notifications by feed#254
Alessandro100 merged 4 commits into
mainfrom
fix/notifications-group-by-feed

Alessandro100 commented Oct 19, 2026 •

edited

Loading

Uh oh!

vercel Bot commented Oct 19, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Oct 19, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Alessandro100 commented Oct 20, 2026

Uh oh!

Alessandro100 commented Oct 20, 2026

Uh oh!

emmambd commented Oct 20, 2026

Uh oh!

abigailmbd left a comment

Uh oh!

davidgamez left a comment

Uh oh!

Uh oh!

This branch was successfully deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

Alessandro100 commented Oct 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Problem

Changes

Testing

Uh oh!

vercel Bot commented Oct 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Oct 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Alessandro100 commented Oct 20, 2026

Uh oh!

Alessandro100 commented Oct 20, 2026

Uh oh!

emmambd commented Oct 20, 2026

Uh oh!

abigailmbd left a comment

Choose a reason for hiding this comment

Uh oh!

davidgamez left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

This branch was successfully deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Alessandro100 commented Oct 19, 2026 •

edited

Loading

vercel Bot commented Oct 19, 2026 •

edited

Loading

github-actions Bot commented Oct 19, 2026 •

edited

Loading