Repository navigation
fix(computer-use): match computer_* tool names in capability gates - #579
Merged
Merged
Conversation
The native Computer Use catalog names its tools computer_*, but the read-only role ceiling and the runtime-availability filter still matched the retired desktop_* prefix. Explore and Verifier could therefore receive computer_* tools, and the tools stayed listed when the Computer Use runtime was unavailable. Fixes #573
dyh-sjtu
added
the
cli
hetaoBackend
approved these changes
Nov 2, 2026
7723qqq
added a commit
to 7723qqq/minimax-code
that referenced
this pull request
Nov 4, 2026
The full residual-diff review against upstream/main (a5a05c2) classified every remaining difference: Bun porting, fork i18n catalogs, F-series behavior, the A17/D2 accepted cost, test-coverage differences, the excluded code-sdk/code-sdk-python boundary, and the registered TUI-A06 plugin-marketplace cluster left for the v2 Agent/Plugin batch. The computer_* capability-gate fix (MiniMax-AI#579) is absorbed, so the revision now advances from 9b9885e to a5a05c2. Also aligns canonical-tool-policy.ts's trailing newline with upstream (a formatting-noise item found by the review). productBaseline stays 0.4.12 and packageRoots is unchanged. check:source re-run after the edit: PASS (4660).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
Fixes #573.
The Computer Use runtime tools are exposed as
computer_*(for examplecomputer_screenshot,computer_click), but two capability gates in the published source still matched the olddesktop_prefix:isComputerUseRuntimeToolNameinpackages/agent-tools/src/desktop/canonical-tool-policy.tspackages/local-runtime-v2/src/service/turn-system/agent-host/assembly/local-turn-tool-catalog.ts(renamed toisComputerToolAvailable)As a result,
computer_*tools were not recognised as Computer Use tools, so they bypassed the canonical-tool policy and were not hidden when Computer Use was unavailable. Both gates now matchcomputer_, consistent with the tool names that are actually registered. Only the local-runtime-v2 path calls these helpers, so no compatibility match fordesktop_is kept.This is a partial port;
release/extraction.jsonsourceRevisionis unchanged.bug,cliValidation
MCODE_VERIFY_REPORT_DIR=<outside repo> pnpm verify(full profile) on revision286304f: PASS — 17 gates passed on darwin (Node 22.20.0)test:windowsskipped (not applicable on macOS);test:release-packageskipped (requires an npm release archive). No live Computer Use session was exercised; the change was not tested on Windows.Publication and contribution checks
release/public-source.json; new tests are declared intest/vitest-suites.jsonwhere applicable. (No files added or removed.)Maintainer handoff
Publication scope or license changes (if any): none.
Shared-source port: complete.
Need help on this PR? Tag
@codesmith-botwith what you need.