Repository navigation
Conversation
Add a --resolution flag to `mmx video generate` and accept 768P in the SDK. The API accepts 768P and 2K for MiniMax-H3, but the CLI and SDK only allowed 2K. Omitting the flag still sends 2K. Co-Authored-By: Claude Opus 5.5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The MiniMax-H3 API accepts
resolutionvalues768Pand2K, but the CLI and SDK only allowed2K. This adds a--resolutionflag tommx video generateand accepts768Pin the SDK.mmx video generate --model MiniMax-H3 --prompt "..." --resolution 768PAPI docs: platform.minimax.io, platform.minimax.cn
Behavior
--resolution 768Por2K2K, so existing usage is unchanged768pBoth SDK request forms (
promptandcontent) accept768P. Help text,README.md,README_CN.md, and the H3 skill are updated.Scope
MiniMax-H3changes. Other H3 variants and legacy models are not touched.src/main.ts, as it does for--ratioand--duration. With no cached region and a failed detection, an invalid value reports the network error instead of the usage error. No generation request is sent in that case.Testing
bun run typecheckpasses.bun run lintreports 0 errors. Its one warning is intest/sdk/speech.test.ts, which this PR does not touch.bun test: 618 pass, 1 fail. The failure istest/agent/zed.test.ts(honors XDG_CONFIG_HOME), which also fails onmainlocally.src/main.tswith--dry-runfor 768P, the default, an invalid value, and a legacy model.🤖 Generated with Claude Code
Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.