Repository navigation
Drop the Owner-approved requirement from the readiness check - #10
Merged
Merged
Conversation
The change log no longer records owner approval, so the checker should not require an Owner-approved: field. --require-approval still requires a new log entry that names every changed node. Co-Authored-By: Claude Haiku 5.5 <[email protected]>
Co-Authored-By: Claude Haiku 5.5 <[email protected]>
mbbill
marked this pull request as ready for review
October 17, 2026 23:36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Item: lint-drop-approval (Architect project)
The change log no longer records owner approval, and nothing checks one. The readiness check still required an
Owner-approved:field on the newest log entry, so an entry written to the current rules failed--require-approval.Changes:
lint.py: removed theOwner-approved:requirement from the readiness check and the form check's field list; the help text for--require-approvalno longer says "approved". The flag and its callers are unchanged.test_lint.py: the test that asserted rejection of a missing approval field now asserts that an entry without the field passes. Run before the change, it failed for both cases. The test that a changed node must be named still fails when it is missing.README.md: dropped the approval example and the statements that CI enforces owner approval in the log.Validation:
python3 -B -m unittest test_lintpasses (24 tests).Consumers (Whitefoot, Firn-wf, Halo-wf, Snowghost-wf) move their pinned revision in their own pull requests; this change takes effect there when they do.
🤖 Generated with Claude Code