Add tests for PerformanceChart, PortfolioOverview, recentlyViewedStore and paperTradingStore - #966
Merged
nanaf6203-bit merged 4 commits intoAug 27, 2026
Conversation
|
@RUKAYAT-CODER Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
🔒 Preview Environment DestroyedThe preview environment for this PR has been torn down. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the missing test coverage for four untested units:
PerformanceChart— chart data derivation and rendering (PerformanceChart has no tests: chart data derivation is uncovered #915)PortfolioOverview— populated, empty, loading and error states (PortfolioOverview has no tests: portfolio aggregation rendering is uncovered #912)recentlyViewedStore— record, dedupe, cap and persistence (recentlyViewedStore has no tests: recent-properties state is uncovered #910)paperTradingStore— position open/close, P&L calculation and reset (paperTradingStore has no tests: simulated trade state is uncovered #908)Closes #915
Closes #912
Closes #910
Closes #908