Skip to content

fix(security): remove orphaned pages router file - #963

Merged
nanaf6203-bit merged 1 commit into
MettaChain:mainfrom
nasalehj:fix/issue-816-remove-orphaned-security-page
Aug 27, 2026
Merged

fix(security): remove orphaned pages router file#963
nanaf6203-bit merged 1 commit into
MettaChain:mainfrom
nasalehj:fix/issue-816-remove-orphaned-security-page

Conversation

@nasalehj

@nasalehj nasalehj commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

Summary

Closes #816

Removes the unused Pages Router security page so the repository has one canonical transaction-security implementation under the App Router. The live implementation remains src/components/security/TransactionSecuritySettings.tsx, which is consumed by the dashboard.

Why

The deleted file was an orphaned Pages Router route with no imports or links, while the application routes through src/app/. Keeping both similarly named implementations increased maintenance and tooling ambiguity without providing user-facing behavior.

What was built

File What it contains
src/pages/security/TransactionSecurity.tsx Deleted the unused 425-line Pages Router implementation.

The active App Router component and its consumers were left unchanged. Repository search confirms that no source reference points to pages/security.

Integration changes outside src/pages/

  • None. No files outside the orphaned Pages Router path were modified.

Acceptance criteria coverage

  • src/pages/ no longer exists. (test ! -e src/pages/security/TransactionSecurity.tsx and the directory is absent after deletion.)
  • npm run typecheck and npm test pass. These commands were run, but the upstream baseline fails independently of this deletion: typecheck/build stop on pre-existing syntax errors in unrelated files, and the full Jest run reports 77 failed suites, 63 passed suites, 159 failed tests, and 986 passed tests.
  • git grep \"pages/security\" returns nothing. (git grep -n -E 'src/pages/security|pages/security|TransactionSecurity' returns no pages/security match.)

Deliberately deferred

  • None.

Test plan

  • git diff --check — passes for the issue-specific diff.
  • git grep -n -E 'src/pages/security|pages/security|TransactionSecurity' -- ':!package-lock.json' — no pages/security references.
  • npm run typecheck — blocked by pre-existing unrelated syntax errors in the upstream baseline.
  • npm test -- --runInBand — blocked by pre-existing repository test failures: 63/140 suites passing and 986/1145 tests passing.
  • npm run build — blocked by the same pre-existing typecheck errors.
  • npm run lint — blocked because the checked-out dependencies do not include eslint-plugin-jsdoc.

Env vars / Notes

No environment variables, configuration values, migrations, or public APIs were added or changed.

@drips-wave

drips-wave Bot commented Aug 26, 2026

Copy link
Copy Markdown

@nasalehj Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@nanaf6203-bit nanaf6203-bit left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nanaf6203-bit
nanaf6203-bit merged commit 89bd311 into MettaChain:main Aug 27, 2026
1 of 4 checks passed
@github-actions

Copy link
Copy Markdown

🔒 Preview Environment Destroyed

The preview environment for this PR has been torn down.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Delete orphaned Pages Router file src/pages/security/TransactionSecurity.tsx

2 participants