fix(security): remove orphaned pages router file - #963
Merged
nanaf6203-bit merged 1 commit intoAug 27, 2026
Merged
Conversation
|
@nasalehj Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
🔒 Preview Environment DestroyedThe preview environment for this PR has been torn down. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #816
Removes the unused Pages Router security page so the repository has one canonical transaction-security implementation under the App Router. The live implementation remains
src/components/security/TransactionSecuritySettings.tsx, which is consumed by the dashboard.Why
The deleted file was an orphaned Pages Router route with no imports or links, while the application routes through
src/app/. Keeping both similarly named implementations increased maintenance and tooling ambiguity without providing user-facing behavior.What was built
src/pages/security/TransactionSecurity.tsxThe active App Router component and its consumers were left unchanged. Repository search confirms that no source reference points to
pages/security.Integration changes outside
src/pages/Acceptance criteria coverage
src/pages/no longer exists. (test ! -e src/pages/security/TransactionSecurity.tsxand the directory is absent after deletion.)npm run typecheckandnpm testpass. These commands were run, but the upstream baseline fails independently of this deletion: typecheck/build stop on pre-existing syntax errors in unrelated files, and the full Jest run reports 77 failed suites, 63 passed suites, 159 failed tests, and 986 passed tests.git grep \"pages/security\"returns nothing. (git grep -n -E 'src/pages/security|pages/security|TransactionSecurity'returns nopages/securitymatch.)Deliberately deferred
Test plan
git diff --check— passes for the issue-specific diff.git grep -n -E 'src/pages/security|pages/security|TransactionSecurity' -- ':!package-lock.json'— nopages/securityreferences.npm run typecheck— blocked by pre-existing unrelated syntax errors in the upstream baseline.npm test -- --runInBand— blocked by pre-existing repository test failures: 63/140 suites passing and 986/1145 tests passing.npm run build— blocked by the same pre-existing typecheck errors.npm run lint— blocked because the checked-out dependencies do not includeeslint-plugin-jsdoc.Env vars / Notes
No environment variables, configuration values, migrations, or public APIs were added or changed.